Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart: template to be used as a side car for this exporter when installing logstash chart from bitnami #17

Closed
pawellegowski89 opened this issue Feb 23, 2023 · 6 comments · Fixed by #66
Closed

Helm chart: template to be used as a side car for this exporter when installing logstash chart from bitnami #17

pawellegowski89 opened this issue Feb 23, 2023 · 6 comments · Fixed by #66

Comments

@pawellegowski89
Copy link

Hi,

I like that finally someone decided to create a current project of a dedicated exporter for logstash metrics in a prometheus-accepted format.

I will try to help and post ready fragments of the values ​​file configuration that will allow you to implement this exporter as a side car together with the installation of the official helm chart from bitnami, which is used to install logstash. In addition, I will add a template that allows you to create a ServiceMonitor if Prometheus has been implemented as an operator. This will ensure that the target registers itself automatically.

I hope this will be helpful in creating a dedicated helm chart for this exporter.
Because there may also be a need to implement it separately, and not together with logstash (version from bitnami).

Regards
Paul
@kuskoman kuskoman mentioned this issue Mar 24, 2023
Merged
10 tasks
@kuskoman
Copy link
Owner

@pawellegowski89 I started working on a helm chart in style similar to this chart: https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus-elasticsearch-exporter/, but feel free to provide any information that may help users to implement logstash exporter as a sidecar for their deployment, as this is not currently my main goal

@excalq
Copy link
Contributor

excalq commented Mar 31, 2023

It'd be great to have this generalized to work with any Logstash deployment. (We use a customized one with a JSON-reponse version of logstash-http-input and OpenSearch output plugins.) Happy to collaborate where possible as well.

@kuskoman
Copy link
Owner

kuskoman commented Apr 1, 2023

@excalq does the approach presented in #66 match your requirements? if not, what changes are required for you to have the chart working properly?
the PR is in an early stage and since I am working on it in free time I cannot promise any deadline for it, but I apperciate any feedback.

@excalq
Copy link
Contributor

excalq commented Apr 10, 2023

That chart looks great, and I'll test it out this week, and give feedback. I hadn't seen the draft PR, but great to see it now - thanks for the link.

@kuskoman
Copy link
Owner

@excalq it is not ready-to-use solution yet, you may need to create fixes/add missing files. i will work on it when i have some free time

@excalq
Copy link
Contributor

excalq commented Apr 11, 2023

Fixes to the chart are posted in PR #74 😀 Next I'd like to get it to export metrics for multiple Logstash replicas, each with their own labels. I'm thinking about what the configuration might look like. Perhaps fetching annotations rather than a static url set in values.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add basic Helm chart for the application kuskoman/logstash-exporter
3 participants
@excalq @kuskoman @pawellegowski89