Don't exit if $GOPATH/src is a symlink #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvalSymlinks() before comparing the `pwd` with $GOPATH/src so that in the case where $GOPATH/src is a symbolic link (to a case sensitive filesystem on a mac for instance) the `kit` command will still execute successfully.
|
@gabeguz This PR looks fine, I have not thought of a use case like this. Adding this is totally fine since it does not change the behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EvalSymlinks() before comparing the
pwdwith $GOPATH/src so that inthe case where $GOPATH/src is a symbolic link (to a case sensitive
filesystem on a mac for instance) the
kitcommand will still executesuccessfully.
I'm not sure if this is too much of an edge case to handle in the code or not, but on my particular setup
$GOPATH/srcis a symlink toVolumes/src, which is a case-sensitive volume on my mac. The reason for this is so that I don't have to worry about issues related to case insensitivity on the standard HFS+ volume.In theory, I could mitigate this issue by moving all of
$GOPATHto /Volumes/src w/out having to change the code.Let me know what you think, and if this change is appropriate or not.