Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation presubmit for sigs.yaml #1160

Merged
merged 1 commit into from
May 3, 2021

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Apr 26, 2021

Adds a presubmit that validates the sigs.yaml whenever it changes.

Signed-off-by: Daniel Hiller <dhiller@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 26, 2021
@mazzystr
Copy link
Contributor

mazzystr commented May 3, 2021

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2021
@dhiller
Copy link
Contributor Author

dhiller commented May 3, 2021

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2021
@kubevirt-bot kubevirt-bot merged commit 0d1084a into kubevirt:master May 3, 2021
@kubevirt-bot
Copy link
Contributor

@dhiller: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key community-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/community/community-presubmits.yaml

In response to this:

Adds a presubmit that validates the sigs.yaml whenever it changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants