Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bazel version and bazel python rules #6326

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Update bazel version and bazel python rules #6326

merged 1 commit into from
Sep 3, 2021

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Aug 31, 2021 •
edited
Loading

What this PR does / why we need it:

Updates the bazel version to latest 4.2.1 in codebase and builder image, and uses the new builder image. Also updates python rules.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS labels Aug 31, 2021
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 31, 2021
@dhiller
Copy link
Contributor Author

dhiller commented Aug 31, 2021

/test all

@dhiller dhiller force-pushed the update-bazel-version-and-python-rules branch from 5a6aef3 to 370e711 Compare August 31, 2021 12:49
@dhiller
Copy link
Contributor Author

dhiller commented Aug 31, 2021

Required for kubevirt/project-infra#1528

@dhiller dhiller marked this pull request as ready for review August 31, 2021 12:58
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2021
@dhiller
Update bazel version and bazel python rules
04bae62 
Signed-off-by: Daniel Hiller <dhiller@redhat.com>
@dhiller dhiller force-pushed the update-bazel-version-and-python-rules branch from 370e711 to 04bae62 Compare August 31, 2021 12:59
@dhiller
Copy link
Contributor Author

dhiller commented Sep 1, 2021

/cc @enp0s3 @fgimenez

@dhiller dhiller mentioned this pull request Sep 1, 2021
Merged
@rmohr
Copy link
Member

rmohr commented Sep 2, 2021

/lgtm
/approve

Do we already pre-pull this bazel version in our bootstrap images?

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2021
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021
@dhiller
Copy link
Contributor Author

dhiller commented Sep 2, 2021

/lgtm
/approve

Do we already pre-pull this bazel version in our bootstrap images?

No, I don't think so.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot
Copy link
Contributor

@dhiller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-kubevirt-e2e-k8s-1.20-sig-storage 04bae62 link /test pull-kubevirt-e2e-k8s-1.20-sig-storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot merged commit 4e9d3a2 into kubevirt:main Sep 3, 2021
@fgimenez
Copy link
Contributor

fgimenez commented Sep 4, 2021

Do we already pre-pull this bazel version in our bootstrap images?

No, I don't think so.

Will be done here kubevirt/project-infra#1546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enp0s3 enp0s3 Awaiting requested review from enp0s3

@fgimenez fgimenez Awaiting requested review from fgimenez

Assignees

@rmohr rmohr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhiller @kubevirt-bot @rmohr @kubevirt-commenter-bot @fgimenez