Reduce libguestfs image size #6077
Conversation
kubevirt-bot
added
release-note-none
|
/cc @alicefr |
|
@andreabolognani FYI: We just do this step now already before #5991 because the image makes building significantly slower. |
|
/lgtm |
rmohr
force-pushed
the
smaller-libguestfs
branch
from
a693609 to
1ff60f4
Compare
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
rmohr
force-pushed
the
smaller-libguestfs
branch
from
1ff60f4 to
02ea799
Compare
|
/unhold |
kubevirt-bot
removed
the
do-not-merge/hold
| libguestfs-tools \ | ||
| --force-ignore-with-dependencies '^(kernel-|linux-firmware)' \ | ||
| --force-ignore-with-dependencies '^(python[3]{0,1}-|perl[3]{0,1}-)' \ | ||
| --force-ignore-with-dependencies '^(mesa-|libwayland-|selinux-policy|mozjs60)' \ |
There was a problem hiding this comment.
Isn't dropping SELinux-related packages a bit too aggressive? Are you sure that's not going to cause any issues?
There was a problem hiding this comment.
I am looking forward to the e2e test results with libguestfs :)
There was a problem hiding this comment.
@andreabolognani I think it should be fine to drop selinux packages. Selinux runs outside the container not inside.
|
/retest |
1 similar comment
|
/retest |
|
/retest @alicefr test results look good, can you have another look? |
|
it looks good. I also tried a couple of libguestfs-tools it seems working fine :) |
|
The diet was also very efficient 1.3G -> 605 MB ;) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rmohr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest |
|
@rmohr the storage tests are failing and they are the guestfs tests. However, it is because the pod is still pending. So, I think it is because the pvc hasn't be bound and it times out. I'll trigger it once more |
|
ok the storage tests are still failing but now the failed tests are not the guestfs tests. So, it was just flaky |
Yes. Something is wrong with them since a few days. |
|
/retest |
kubevirt-bot
added
the
needs-rebase
bazeldnf now has an option to ignore dependencies which helps reducing image sizes. Signed-off-by: Roman Mohr <rmohr@redhat.com>
Ignore a first set of definitely unwanted dependencies. Possibly more can be removed. Signed-off-by: Roman Mohr <rmohr@redhat.com>
Signed-off-by: Roman Mohr <rmohr@redhat.com>
rmohr
force-pushed
the
smaller-libguestfs
branch
from
02ea799 to
a9b558e
Compare
kubevirt-bot
removed
lgtm
|
@alicefr rebased. Could you restore the lgtm? |
|
/lgtm |
|
/retest |
What this PR does / why we need it:
Exclude quite a bunch of RPMs which are not needed by libguestfs but are pulled in automatically due to RPM dependencies. Reduces the size of pulled in dependencies from roughly 1.3 GB to 500 M.
More dependencies can be removed. This is just a first pass. Thanks @alicefr for providing initial investigations on potential candidates for removal.
This step is needed to achieve two goals:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: