Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go versionm 1.16.1 -> 1.16.6 #6034

Merged
merged 1 commit into from
Jul 22, 2021
Merged

update go versionm 1.16.1 -> 1.16.6 #6034

merged 1 commit into from
Jul 22, 2021

Conversation

ashleyschuett
Copy link
Contributor

Signed-off-by: Ashley Schuett aschuett@redhat.com

What this PR does / why we need it:
Update go version

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Go version updated to version 1.16.6

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 13, 2021
@xpivarc
Copy link
Member

xpivarc commented Jul 13, 2021

Do we want to update the builder image too?

@ashleyschuett
update go versionm 1.16.1 -> 1.16.6
0294004 
Signed-off-by: Ashley Schuett <aschuett@redhat.com>
@ashleyschuett
Copy link
Contributor Author

@xpivarc thanks for the reminder. I think I did it correctly now?

@xpivarc
Copy link
Member

xpivarc commented Jul 14, 2021

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2021
@iholder101
Copy link
Contributor

Thanks @ashleyschuett !

I'm a bit concerned that go rules don't fully support Go 1.16.6.

The latest go rules version (v0.24.14) that said something about supporting new Go versions says: Go 1.16.2, 1.16.1, 1.15.10, and 1.15.9 are now supported. In their latest version's release notes (v0.28.0) they use go_register_toolchains(version = "1.16.5").

On the other hand - I see that CI lanes ended up generally fine.. I would appreciate another opinion on this :)

@iholder101
Copy link
Contributor

/test pull-kubevirt-e2e-k8s-1.19-sig-storage

@ashleyschuett
Copy link
Contributor Author

In their latest version's release notes (v0.28.0) they use go_register_toolchains(version = "1.16.5").

I can downgrad this to instead use 1.16.5 if that's better? Maybe @dhiller has an opinion?

@dhiller
Copy link
Contributor

dhiller commented Jul 21, 2021

In their latest version's release notes (v0.28.0) they use go_register_toolchains(version = "1.16.5").

I can downgrad this to instead use 1.16.5 if that's better? Maybe @dhiller has an opinion?

Sorry, missed the notification on this.

IMHO if everything works, we should leave it like this.

@ashleyschuett
Copy link
Contributor Author

IMHO if everything works, we should leave it like this.

@dhiller are you okay with giving it an approve then? :)

@rmohr
Copy link
Member

rmohr commented Jul 21, 2021

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021
@kubevirt-bot kubevirt-bot merged commit 44efbf2 into kubevirt:main Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlonaKaplan AlonaKaplan Awaiting requested review from AlonaKaplan

@jean-edouard jean-edouard Awaiting requested review from jean-edouard

Assignees

@xpivarc xpivarc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ashleyschuett @xpivarc @iholder101 @dhiller @rmohr @kubevirt-bot