Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix artifacts in gosec target #4379

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Fix artifacts in gosec target #4379

merged 1 commit into from
Oct 21, 2020

Conversation

xpivarc
Copy link
Member

@xpivarc xpivarc commented Oct 19, 2020

What this PR does / why we need it:
Moves the junit file to correct directory.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

"NONE"

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Oct 19, 2020
enp0s3
enp0s3 reviewed Oct 19, 2020
View reviewed changes
Copy link
Contributor

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a small nit below

hack/gosec.sh Outdated Show resolved Hide resolved
@xpivarc
Fix artifacts in gosec target
4f5012b 
Signed-off-by: L. Pivarc <lpivarc@redhat.com>
@xpivarc xpivarc force-pushed the fix-gosec-artifacts branch from 5faa10f to 4f5012b Compare October 19, 2020 12:41
enp0s3
enp0s3 approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2020
@xpivarc
Copy link
Member Author

xpivarc commented Oct 20, 2020

/test pull-kubevirt-gosec

@openshift-ci-robot
Copy link
Collaborator

@xpivarc: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-kubevirt-gosec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhiller
Copy link
Contributor

dhiller commented Oct 20, 2020

/lgtm
/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2020
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit fc27222 into kubevirt:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enp0s3 enp0s3 enp0s3 approved these changes

@AlonaKaplan AlonaKaplan Awaiting requested review from AlonaKaplan

Assignees

@dhiller dhiller

@enp0s3 enp0s3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xpivarc @openshift-ci-robot @dhiller @kubevirt-bot @kubevirt-commenter-bot @enp0s3