Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instancetype: Harden CR upgrade func test #12741

Merged
merged 1 commit into from
Sep 6, 2024
Merged

instancetype: Harden CR upgrade func test #12741

merged 1 commit into from
Sep 6, 2024

Conversation

lyarwood
Copy link
Member

@lyarwood lyarwood commented Sep 5, 2024 •
edited
Loading

What this PR does

When replacing the original CR the test asserts that it is removed from the cluster. This can take the controller some time to complete in a busy env so move this check into an Eventually call.

Reported downstream within RH under https://issues.redhat.com/browse/CNV-48098 with the following trace:

tests/instancetype/upgrade.go:340
Expected an error to have occurred.  Got:
    <nil>: nil
tests/instancetype/upgrade.go:178

AFAICT this hasn't failed recently upstream searching on search.ci.kubevirt.io

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

NONE

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S area/instancetype sig/compute labels Sep 5, 2024
@lyarwood lyarwood changed the title WIP instancetype: Harden CR upgrade func test instancetype: Harden CR upgrade func test Sep 5, 2024
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 5, 2024
@lyarwood lyarwood marked this pull request as ready for review September 5, 2024 09:30
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2024
@dosubot dosubot bot added the sig/testing label Sep 5, 2024
@lyarwood lyarwood force-pushed the instancetype-upgrade-func-test-harden branch from a430ff3 to b86dcf3 Compare September 5, 2024 12:06
@lyarwood
instancetype: Harden CR upgrade func test
8ba7039 
When replacing the original CR the test asserts that it is removed from
the cluster. This can take the controller some time to complete in a
busy env so move this check into an Eventually call.

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@lyarwood lyarwood force-pushed the instancetype-upgrade-func-test-harden branch from b86dcf3 to 8ba7039 Compare September 5, 2024 12:14
0xFelix
0xFelix reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2024
@kubevirt-commenter-bot
Copy link

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.27-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-storage
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-operator
/test pull-kubevirt-e2e-k8s-1.30-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-storage
/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.30-sig-operator

@lyarwood
Copy link
Member Author

lyarwood commented Sep 6, 2024

/test pull-kubevirt-e2e-k8s-1.29-sig-storage

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Sep 6, 2024 •
edited
Loading

@lyarwood: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-arm64 8ba7039 link false /test pull-kubevirt-e2e-arm64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lyarwood
Copy link
Member Author

lyarwood commented Sep 6, 2024

/test pull-kubevirt-e2e-k8s-1.29-sig-storage

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 896ec95 into kubevirt:main Sep 6, 2024
38 of 39 checks passed
@lyarwood
Copy link
Member Author

/cherry-pick release-1.3

@kubevirt-bot
Copy link
Contributor

@lyarwood: new pull request created: #12849

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@xpivarc xpivarc xpivarc approved these changes

@akrejcir akrejcir Awaiting requested review from akrejcir

@victortoso victortoso Awaiting requested review from victortoso

Assignees

@xpivarc xpivarc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/instancetype dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/compute sig/testing size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lyarwood @kubevirt-bot @kubevirt-commenter-bot @0xFelix @xpivarc