Add sigs validator #100
Add sigs validator #100
Conversation
Signed-off-by: Daniel Hiller <dhiller@redhat.com>
Command: $ go run validators/cmd/sigs/sigs-validator.go --sigs_file_path=./sigs.yaml --dry-run=false Signed-off-by: Daniel Hiller <dhiller@redhat.com>
Signed-off-by: Daniel Hiller <dhiller@redhat.com>
kubevirt-bot
added
dco-signoff: yes
|
/lgtm |
|
/retest |
Signed-off-by: Daniel Hiller <dhiller@redhat.com>
|
@mazzystr sorry, had to fix error regarding the devstats generator, PTAL! Thanks! |
|
Please see kubevirt/project-infra#1160, there I have added a validation presubmit, so that we can be sure it is correct whenever it changes. |
|
/approve @dhiller do you want anyone else to approve? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mazzystr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
| func (o *options) Validate() error { | ||
| if o.sigsFilePath == "" { | ||
| return fmt.Errorf("path to sigs.yaml is required") | ||
| } else { |
There was a problem hiding this comment.
I think we can remove tihs else
| if response.StatusCode >= http.StatusOK && response.StatusCode < http.StatusMultipleChoices { | ||
| foundOwners = append(foundOwners, ownersFileURL) | ||
| } else { | ||
| log.Printf("failed to retrieve %s", ownersFileURL) |
There was a problem hiding this comment.
Would be good to add response.StatusCode here.
Signed-off-by: Daniel Hiller <dhiller@redhat.com>
|
@fgimenez addressed review comments, PTAL! Thanks! |
This PR adds a tool that can validate the basics of the
sigs.yamlfile. Currently it can validate/remove non existing links to owners elements.Also it updates the sigs.yaml with removed unreachable owners links.
/cc @mazzystr @fabiand @fgimenez