alerting v2beta1 tunes #5200
Merged
alerting v2beta1 tunes #5200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ks-ci-bot
added
release-note-none
kind/feature
benjaminhuo
reviewed
Sep 7, 2022
| RulesStats RulesStats `json:"rulesStats,omitempty" description:"statistics of rules in one RuleGroup"` | ||
| } | ||
|
|
||
| type RulesStats struct { |
There was a problem hiding this comment.
can be changed to
type RulesStats struct {
Inactive int `json:"inactive" description:"count of rules in the inactive state"`
Pending int `json:"pending" description:"count of rules in the pending state"`
Firing int `json:"firing" description:"count of rules in the firing state"`
Disabled int `json:"disabled" description:"count of disabled rules"`
}There was a problem hiding this comment.
These are adj, not nouns.
So we shouldn't add s to them
Signed-off-by: junot <junotxiang@kubesphere.io>
|
/lgtm |
|
LGTM label has been added. Git tree hash: 7fe492f5bd99ed55d45a4ce54c26f0bf9d74d60b
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminhuo, junotx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
the
approved
zhou1203
pushed a commit
that referenced
this pull request
Oct 15, 2022
Signed-off-by: junot <junotxiang@kubesphere.io> Signed-off-by: junot <junotxiang@kubesphere.io>
sologgfun
pushed a commit
to sologgfun/kubesphere
that referenced
this pull request
Apr 24, 2023
Signed-off-by: junot <junotxiang@kubesphere.io> Signed-off-by: junot <junotxiang@kubesphere.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
It is a supplement for #5115:
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: