Replace the Helm command #4852

nioshield · 2022-05-06T08:13:44Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Use Helm action package directly to manage Helm Releases, avoiding dependency on helm/kustomize Command.The Helm can be flexibly configured

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

ks-ci-bot · 2022-05-06T08:13:55Z

Hi @nioshield. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xyz-li · 2022-05-06T08:29:47Z

/ok-to-test

wansir · 2022-05-06T08:36:33Z

@nioshield Thanks for your contribution! The job pull-kubesphere-verify is failed, you can get more information about this, refer to https://prow.kubesphere.io/view/s3/prow-logs/pr-logs/pull/kubesphere_kubesphere/4852/pull-kubesphere-verify/1522493840206860288.

wansir · 2022-05-06T08:42:05Z

/cc @kubesphere/sig-apps

xyz-li · 2022-05-06T08:56:08Z

/cc @zheng1

nioshield · 2022-05-06T09:17:19Z

/retest

pkg/simple/client/openpitrix/helmwrapper/helm_wrapper.go

xyz-li · 2022-05-06T09:24:40Z

pkg/simple/client/openpitrix/helmwrapper/helm_wrapper.go

-		Stdout: stdout,
-	}
+	klog.V(2).Infof("namespace: %s, name: %s, run command success", c.Namespace, c.ReleaseName)
+	klog.V(8).Infof("namespace: %s, name: %s, run command success, release: %v", c.Namespace, c.ReleaseName, rel)


rel is a struct, if we use %v to format it, the output is difficult to read.

We should encode rel to string.

yes,It's enough to output rel.Manifest here

wansir · 2022-05-13T11:27:46Z

pkg/simple/client/openpitrix/helmwrapper/helm_wrapper.go

+	if kubeconfig != "" {
+		cfg, _ := clientcmd.RESTConfigFromKubeConfig([]byte(kubeconfig))
+		flags = genericclioptions.NewConfigFlags(false)
+		flags.APIServer = &cfg.Host
+		flags.BearerToken = &cfg.BearerToken
+		flags.CAFile = &cfg.CAFile
+		flags.WithDiscoveryBurst(cfg.Burst)
+		if sa := cfg.Impersonate.UserName; sa != "" {
+			flags.Impersonate = &sa
+		}
+	}


The following code will cause a cert error if the kubefonfig includes certificate-authority-data.

E0513 11:24:17.485511 1 helm_wrapper.go:107] namespace: z1, name: redis-emjr1v, run command failed, error: Kubernetes cluster unreachable: Get "https://10.233.0.1:443/version?timeout=32s": x509: certificate signed by unknown authority

Wrapped RESTClientGetter

ttype restClientGetter struct { config clientcmd.ClientConfig } func (r *restClientGetter) ToRawKubeConfigLoader() clientcmd.ClientConfig { return r.config } func (r *restClientGetter) ToRESTConfig() (*rest.Config, error) { return r.ToRawKubeConfigLoader().ClientConfig() } func (r *restClientGetter) ToDiscoveryClient() (discovery.CachedDiscoveryInterface, error) { config, err := r.ToRESTConfig() if err != nil { return nil, err } discoveryClient, err := discovery.NewDiscoveryClientForConfig(config) if err != nil { return nil, err } clientset := memory.NewMemCacheClient(discoveryClient) return clientset, nil }

wansir · 2022-05-13T11:27:46Z

pkg/simple/client/openpitrix/helmwrapper/helm_wrapper.go

+	if kubeconfig != "" {
+		cfg, _ := clientcmd.RESTConfigFromKubeConfig([]byte(kubeconfig))
+		flags = genericclioptions.NewConfigFlags(false)
+		flags.APIServer = &cfg.Host
+		flags.BearerToken = &cfg.BearerToken
+		flags.CAFile = &cfg.CAFile
+		flags.WithDiscoveryBurst(cfg.Burst)
+		if sa := cfg.Impersonate.UserName; sa != "" {
+			flags.Impersonate = &sa
+		}
+	}


The following code will cause a cert error if the kubefonfig includes certificate-authority-data.

E0513 11:24:17.485511 1 helm_wrapper.go:107] namespace: z1, name: redis-emjr1v, run command failed, error: Kubernetes cluster unreachable: Get "https://10.233.0.1:443/version?timeout=32s": x509: certificate signed by unknown authority

Thanks for your reply.the multi cluster kubeconfig havn't check err,i will fix this err.In addition how can i fast to mock a multi cluster env

Thanks for your reply.the multi cluster kubeconfig havn't check err,i will fix this err.In addition how can i fast to mock a multi cluster env

sigs.k8s.io/controller-runtime/pkg/envtest may be helpful for you.

Thanks to your help, I created the MemoryRESTClientGetter to solve this problem

wansir · 2022-05-23T07:51:09Z

LGTM @xyz-li Any comments?

xyz-li · 2022-05-25T01:59:01Z

LGTM @xyz-li Any comments?

Merge after v3.3.0 is released.

wansir · 2022-05-29T15:23:55Z

/hold
/lgtm

ks-ci-bot · 2022-05-29T15:24:01Z

LGTM label has been added.

Git tree hash: 4c6a057aa056469ed7cddb5af8a307a3a8cc1e3d

zheng1 · 2022-06-27T06:49:56Z

Hi, @nioshield have you tried installing the following chart?
https://github.com/kubesphere/helm-charts/tree/master/src/main/mysql
In our previous experience, it may fail because the helm package may not be able to handle the tests folder correctly

wansir · 2022-06-27T07:32:31Z

/retest

wansir · 2022-06-27T08:36:17Z

Hi, @nioshield have you tried installing the following chart? https://github.com/kubesphere/helm-charts/tree/master/src/main/mysql In our previous experience, it may fail because the helm package may not be able to handle the tests folder correctly

I have verified this pr, it works.

wansir · 2022-06-27T08:38:25Z

/unhold
/approve

ks-ci-bot · 2022-06-27T08:38:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nioshield, wansir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/simple/client/openpitrix/OWNERS~~ [wansir]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Replace the helm command line with helm action * fix log misspelling * helm wrapper formate log msg * fix: helm action faild in multi cluster

ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-ok-to-test labels May 6, 2022

ks-ci-bot added ok-to-test and removed needs-ok-to-test labels May 6, 2022

ks-ci-bot requested a review from zheng1 May 6, 2022 08:56

xyz-li reviewed May 6, 2022

View reviewed changes

wansir reviewed May 13, 2022

View reviewed changes

nioshield added 4 commits May 24, 2022 17:54

Replace the helm command line with helm action

26b0295

fix log misspelling

4bd891c

helm wrapper formate log msg

f3b2468

fix: helm action faild in multi cluster

3572790

ks-ci-bot added the do-not-merge/hold label May 29, 2022

ks-ci-bot assigned wansir May 29, 2022

ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2022

ks-ci-bot added release-note-none and removed do-not-merge/release-note-label-needed labels Jun 27, 2022

ks-ci-bot removed the do-not-merge/hold label Jun 27, 2022

ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2022

ks-ci-bot merged commit fe992ae into kubesphere:master Jun 27, 2022

nioshield mentioned this pull request Jul 5, 2022

Delete Helm and Kustomize binaries in Dockerfile #5031

Closed

sologgfun pushed a commit to sologgfun/kubesphere that referenced this pull request Apr 24, 2023

Replace the Helm command (kubesphere#4852)

6a082ad

* Replace the helm command line with helm action * fix log misspelling * helm wrapper formate log msg * fix: helm action faild in multi cluster

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace the Helm command #4852

Replace the Helm command #4852

nioshield commented May 6, 2022 •

edited by wansir

Loading

ks-ci-bot commented May 6, 2022

xyz-li commented May 6, 2022

wansir commented May 6, 2022

wansir commented May 6, 2022

xyz-li commented May 6, 2022

nioshield commented May 6, 2022

xyz-li May 6, 2022

xyz-li May 6, 2022

nioshield May 6, 2022

wansir May 13, 2022

wansir May 13, 2022 •

edited

Loading

wansir May 13, 2022

nioshield May 16, 2022 •

edited

Loading

wansir May 17, 2022

nioshield May 18, 2022

wansir commented May 23, 2022

xyz-li commented May 25, 2022

wansir commented May 29, 2022

ks-ci-bot commented May 29, 2022

zheng1 commented Jun 27, 2022

wansir commented Jun 27, 2022

wansir commented Jun 27, 2022

wansir commented Jun 27, 2022

ks-ci-bot commented Jun 27, 2022

Replace the Helm command #4852

Replace the Helm command #4852

Conversation

nioshield commented May 6, 2022 • edited by wansir Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewers:

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

ks-ci-bot commented May 6, 2022

xyz-li commented May 6, 2022

wansir commented May 6, 2022

wansir commented May 6, 2022

xyz-li commented May 6, 2022

nioshield commented May 6, 2022

xyz-li May 6, 2022

Choose a reason for hiding this comment

xyz-li May 6, 2022

Choose a reason for hiding this comment

nioshield May 6, 2022

Choose a reason for hiding this comment

wansir May 13, 2022

Choose a reason for hiding this comment

wansir May 13, 2022 • edited Loading

Choose a reason for hiding this comment

wansir May 13, 2022

Choose a reason for hiding this comment

nioshield May 16, 2022 • edited Loading

Choose a reason for hiding this comment

wansir May 17, 2022

Choose a reason for hiding this comment

nioshield May 18, 2022

Choose a reason for hiding this comment

wansir commented May 23, 2022

xyz-li commented May 25, 2022

wansir commented May 29, 2022

ks-ci-bot commented May 29, 2022

zheng1 commented Jun 27, 2022

wansir commented Jun 27, 2022

wansir commented Jun 27, 2022

wansir commented Jun 27, 2022

ks-ci-bot commented Jun 27, 2022

nioshield commented May 6, 2022 •

edited by wansir

Loading

wansir May 13, 2022 •

edited

Loading

nioshield May 16, 2022 •

edited

Loading