Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dead links in readme #3039

Merged
merged 1 commit into from
Oct 29, 2020
Merged

fix dead links in readme #3039

merged 1 commit into from
Oct 29, 2020

Conversation

stoneshi-yunify
Copy link
Member

@stoneshi-yunify stoneshi-yunify commented Oct 28, 2020 •
edited by zryfish
Loading

Signed-off-by: stoneshi-yunify stoneshi@yunify.com

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Additional documentation, usage docs, etc.:

@stoneshi-yunify
fix dead links in readme
b792438 
Signed-off-by: stoneshi-yunify <stoneshi@yunify.com>
@ks-ci-bot ks-ci-bot added kind/documentation Categorizes issue or PR as related to documentation. dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2020
@stoneshi-yunify
Copy link
Member Author

/cc @zryfish

Exact same changes with #3037, but with signoff

@ks-ci-bot ks-ci-bot requested a review from zryfish October 28, 2020 10:13
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #3039 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3039      +/-   ##
==========================================
+ Coverage    9.98%   10.03%   +0.05%     
==========================================
  Files         195      195              
  Lines       39011    39011              
==========================================
+ Hits         3894     3915      +21     
+ Misses      34552    34531      -21     
  Partials      565      565
Flag Coverage Δ
#unittests 10.03% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...roller/virtualservice/virtualservice_controller.go 36.32% <0.00%> (-6.00%) ⬇️
...er/devopscredential/devopscredential_controller.go 31.49% <0.00%> (-3.94%) ⬇️
...ntroller/devopsproject/devopsproject_controller.go 41.70% <0.00%> (+2.51%) ⬆️
pkg/controller/pipeline/pipeline_controller.go 41.17% <0.00%> (+4.20%) ⬆️
...ller/destinationrule/destinationrule_controller.go 51.36% <0.00%> (+14.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abe9975...b792438. Read the comment docs.

@FeynmanZhou
Copy link
Member

/lgtm

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeynmanZhou, stoneshi-yunify
To complete the pull request process, please assign rayzhou2017
You can assign the PR to them by writing /assign @rayzhou2017 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FeynmanZhou FeynmanZhou merged commit b4ab781 into kubesphere:master Oct 29, 2020
zackzhangkai pushed a commit to zackzhangkai/kubesphere that referenced this pull request Oct 30, 2020
Merge pull request kubesphere#3039 from stoneshi-yunify/fix-readme
96c9574 
fix dead links in readme

Signed-off-by: zackzhangkai <zackzhang@yunify.com>
zackzhangkai pushed a commit to zackzhangkai/kubesphere that referenced this pull request Oct 30, 2020
Merge pull request kubesphere#3039 from stoneshi-yunify/fix-readme
5a0cd13 
fix dead links in readme

Signed-off-by: zackzhangkai <zackzhang@yunify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FeynmanZhou FeynmanZhou FeynmanZhou approved these changes

@zryfish zryfish Awaiting requested review from zryfish

Assignees
No one assigned
Labels
dco-signoff: yes kind/documentation Categorizes issue or PR as related to documentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stoneshi-yunify @FeynmanZhou @ks-ci-bot