Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix application status #3014

Merged
merged 1 commit into from
Oct 15, 2020
Merged

fix application status #3014

merged 1 commit into from
Oct 15, 2020

Conversation

zackzhangkai
Copy link
Contributor

@zackzhangkai zackzhangkai commented Oct 13, 2020 •
edited
Loading

What type of PR is this?
fix application status when add component

/kind bug

@ks-ci-bot ks-ci-bot added dco-signoff: no size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2020
fix application status
d1e7f35 
Signed-off-by: zackzhangkai <zackzhang@yunify.com>
@ks-ci-bot ks-ci-bot added dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. and removed dco-signoff: no labels Oct 13, 2020
@zackzhangkai
Copy link
Contributor Author

/assign @zryfish

@codecov
Copy link

codecov bot commented Oct 13, 2020 •
edited
Loading

Codecov Report

Merging #3014 into master will increase coverage by 0.25%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3014      +/-   ##
=========================================
+ Coverage    9.74%   9.99%   +0.25%     
=========================================
  Files         195     195              
  Lines       39870   38919     -951     
=========================================
+ Hits         3884    3890       +6     
+ Misses      35425   34465     -960     
- Partials      561     564       +3
Flag Coverage Δ
#unittests 9.99% <0.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/controller/application/application_controller.go 0.00% <0.00%> (ø)
pkg/controller/pipeline/pipeline_controller.go 36.97% <0.00%> (-4.21%) ⬇️
...er/devopscredential/devopscredential_controller.go 31.49% <0.00%> (-3.94%) ⬇️
...here/pkg/apis/tenant/v1alpha1/openapi_generated.go
...pkg/apis/servicemesh/v1alpha2/openapi_generated.go
...ere/pkg/apis/network/v1alpha1/openapi_generated.go
...here/pkg/apis/devops/v1alpha1/openapi_generated.go
...here/pkg/apis/devops/v1alpha3/openapi_generated.go
pkg/apis/network/v1alpha1/openapi_generated.go 0.00% <0.00%> (ø)
pkg/apis/tenant/v1alpha1/openapi_generated.go 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9961a1d...d1e7f35. Read the comment docs.

@zryfish
Copy link
Member

zryfish commented Oct 15, 2020

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2020
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zackzhangkai, zryfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2020
@ks-ci-bot ks-ci-bot merged commit ffa995f into kubesphere:master Oct 15, 2020
@zackzhangkai zackzhangkai mentioned this pull request Nov 2, 2020
Closed
8 tasks
@zryfish zryfish mentioned this pull request Nov 8, 2020
Closed
@zackzhangkai zackzhangkai deleted the fix_app_status branch December 25, 2020 05:13
@zackzhangkai zackzhangkai mentioned this pull request Dec 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zryfish zryfish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zackzhangkai @zryfish @ks-ci-bot