Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add status deleting of volumesnapshot #2980

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Conversation

min-zh
Copy link
Contributor

@min-zh min-zh commented Sep 21, 2020

Signed-off-by: zhangmin arminzhang@yunify.com

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add "deleting status" of VolumeSnapshot

Signed-off-by: zhangmin <arminzhang@yunify.com>
@min-zh
Copy link
Contributor Author

min-zh commented Sep 21, 2020

/cc @zryfish

@ks-ci-bot ks-ci-bot requested a review from zryfish September 21, 2020 03:48
@ks-ci-bot ks-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 21, 2020
@shaowenchen
Copy link
Contributor

/assign @zryfish

@zryfish
Copy link
Member

zryfish commented Oct 9, 2020

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: min-zh, zryfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2020
@ks-ci-bot ks-ci-bot merged commit 98bcc70 into kubesphere:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants