Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme to v3.0.0. #2971

Merged
merged 2 commits into from
Sep 11, 2020
Merged

update readme to v3.0.0. #2971

merged 2 commits into from
Sep 11, 2020

Conversation

FeynmanZhou
Copy link
Member

Signed-off-by: FeynmanZhou pengfeizhou@yunify.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Additional documentation, usage docs, etc.:


Signed-off-by: FeynmanZhou <pengfeizhou@yunify.com>
@ks-ci-bot ks-ci-bot added kind/documentation Categorizes issue or PR as related to documentation. dco-signoff: yes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 10, 2020
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #2971 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2971      +/-   ##
==========================================
- Coverage   10.78%   10.70%   -0.09%     
==========================================
  Files         194      194              
  Lines       41988    41988              
==========================================
- Hits         4527     4493      -34     
- Misses      36885    36922      +37     
+ Partials      576      573       -3     
Flag Coverage Δ
#unittests 10.70% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ller/destinationrule/destinationrule_controller.go 35.68% <0.00%> (-11.21%) ⬇️
pkg/controller/s2irun/s2irun_controller.go 33.78% <0.00%> (-3.38%) ⬇️
...work/nsnetworkpolicy/nsnetworkpolicy_controller.go 33.99% <0.00%> (-2.22%) ⬇️
pkg/controller/user/user_controller.go 20.39% <0.00%> (+1.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 454caf2...22aa18b. Read the comment docs.

README.md Outdated

Install KubeSphere using kubectl.
- [Installing KubeSphere on Amazone EKS](https://kubesphere.io/docs/installing-on-kubernetes/hosted-kubernetes/install-kubesphere-on-eks/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its better to point to the specific version link since this URL will be changed to newer version.

Copy link
Member Author

@FeynmanZhou FeynmanZhou Sep 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about replacing the URL with https://v3-0.docs.kubesphere.io/docs/?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that's what I am talking about.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@FeynmanZhou FeynmanZhou requested a review from zryfish September 10, 2020 08:43
@FeynmanZhou FeynmanZhou changed the title update readme to 3.00. update readme to v3.0.0. Sep 10, 2020
Signed-off-by: FeynmanZhou <pengfeizhou@yunify.com>
| Kubernetes Resource Management | Provide web console for creating and managing Kubernetes resources, with powerful observability including monitoring, logging, events, alerting and notification |
| DevOps System | Provide out-of-box CI/CD based on Jenkins, and offers automated workflow tools including binary-to-image (B2I) and source-to-image (S2I) |
| Application Store | Provide application store for Helm-based applications, and offers application lifecycle management |
| Service Mesh (Istio-based) | Provide fine-grained traffic management, observability and tracing for distributed microservice applications, provides visualization for traffic topology |
| Rich Observability | Provide multi-dimensional monitoring metrics, and provides multi-tenant log query and collection, support alerting and notification for both application and infrastructure |
| Rich Observability | Provide multi-dimensional monitoring metrics, and provides multi-tenant logging, events and [auditing](https://kubernetes.io/docs/tasks/debug-application-cluster/audit/) management, support alerting and notification for both application and infrastructure |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to check all links and change them to v3 doc if possible.

@zryfish
Copy link
Member

zryfish commented Sep 11, 2020

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FeynmanZhou, zryfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020
@ks-ci-bot ks-ci-bot merged commit ca34a8c into kubesphere:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants