Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: get password from kubesphere-config error in init-container #938

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

yudong2015
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Please check the following list before waiting reviewers:

  • Already committed the CRD files to the Helm Chart if you created some new CRDs
  • Already added the permission for the new API
  • Already added the RBAC markers for the new controllers

Does this PR introduce a user-facing change??

none

@yudong2015 yudong2015 requested a review from chilianyi April 12, 2023 17:57
@ks-ci-bot ks-ci-bot requested a review from a team April 12, 2023 17:57
@ks-ci-bot ks-ci-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 12, 2023
@yudong2015
Copy link
Collaborator Author

/cherrypick release-3.4

@ks-ci-bot
Copy link
Collaborator

@yudong2015: once the present PR merges, I will cherry-pick it on top of release-3.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yudong2015 yudong2015 force-pushed the bugfix-init-config-error branch from 88a16ff to f855638 Compare April 13, 2023 04:22
@chilianyi
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chilianyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2023
@ks-ci-bot ks-ci-bot merged commit af744d5 into kubesphere:master Apr 13, 2023
@ks-ci-bot
Copy link
Collaborator

@yudong2015: new pull request created: #939

In response to this:

/cherrypick release-3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chilianyi pushed a commit to chilianyi/ks-devops that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants