Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go-scm to v1.11.19 #786

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Upgrade go-scm to v1.11.19 #786

merged 1 commit into from
Aug 17, 2022

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented Aug 16, 2022 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Please check the following list before waiting reviewers:

  • Already committed the CRD files to the Helm Chart if you created some new CRDs
  • Already added the permission for the new API
  • Already added the RBAC markers for the new controllers

Does this PR introduce a user-facing change??

None

@ks-ci-bot ks-ci-bot requested a review from a team August 16, 2022 09:45
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from linuxsuren after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none and removed do-not-merge/release-note-label-needed labels Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #786 (fba1e1c) into master (757de95) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
+ Coverage   79.47%   79.49%   +0.02%     
==========================================
  Files         171      172       +1     
  Lines       24194    24195       +1     
==========================================
+ Hits        19229    19235       +6     
+ Misses       4680     4675       -5     
  Partials      285      285
Flag Coverage Δ
unittests 79.49% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../gitrepository/gitrepository_webhook_controller.go 94.26% <100.00%> (ø)
pkg/kapis/devops/v1alpha3/scm/scmhandler.go 83.67% <100.00%> (ø)
pkg/api/devops/v1alpha1/groupversion_info.go 100.00% <0.00%> (ø)
...ns/devopscredential/devopscredential_controller.go 36.73% <0.00%> (+3.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LinuxSuRen LinuxSuRen merged commit f6bdaeb into kubesphere:master Aug 17, 2022
@LinuxSuRen LinuxSuRen deleted the upgrade-go-scm branch August 17, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinuxSuRen @ks-ci-bot