Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jenkins edit mode #747

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Fix jenkins edit mode #747

merged 2 commits into from
Jul 22, 2022

Conversation

LinuxSuRen
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

This is the missing part of #746

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Please check the following list before waiting reviewers:

  • Already committed the CRD files to the Helm Chart if you created some new CRDs
  • Already added the permission for the new API
  • Already added the RBAC markers for the new controllers

Does this PR introduce a user-facing change??

None

@ks-ci-bot ks-ci-bot requested a review from a team July 22, 2022 05:29
@ks-ci-bot ks-ci-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 22, 2022
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from linuxsuren after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 22, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #747 (37d3eb2) into master (865043b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #747      +/-   ##
==========================================
+ Coverage   78.25%   78.27%   +0.02%     
==========================================
  Files         157      157              
  Lines       23809    23811       +2     
==========================================
+ Hits        18631    18638       +7     
+ Misses       4924     4921       -3     
+ Partials      254      252       -2
Flag Coverage Δ
unittests 78.27% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/models/devops/devops.go 24.42% <100.00%> (+0.31%) ⬆️
...ns/devopscredential/devopscredential_controller.go 33.33% <0.00%> (-3.41%) ⬇️
.../jenkins/devopsproject/devopsproject_controller.go 43.22% <0.00%> (+2.60%) ⬆️
...ontrollers/jenkins/pipeline/pipeline_controller.go 43.18% <0.00%> (+3.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865043b...37d3eb2. Read the comment docs.

@LinuxSuRen LinuxSuRen merged commit 40ec4b7 into kubesphere:master Jul 22, 2022
@LinuxSuRen LinuxSuRen deleted the fix-jenkins-edit-mode branch July 22, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinuxSuRen @ks-ci-bot