Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo fix: annotation->annotations #683

Merged
merged 1 commit into from
Jun 26, 2022
Merged

typo fix: annotation->annotations #683

merged 1 commit into from
Jun 26, 2022

Conversation

usernameisnull
Copy link
Contributor

What type of PR is this?

/kind chore

What this PR does / why we need it:

just fix a typo

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Please check the following list before waiting reviewers:

  • Already committed the CRD files to the Helm Chart if you created some new CRDs
  • Already added the permission for the new API
  • Already added the RBAC markers for the new controllers

Does this PR introduce a user-facing change??

None

@ks-ci-bot ks-ci-bot requested a review from a team June 25, 2022 14:47
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign linuxsuren after the PR has been reviewed.
You can assign the PR to them by writing /assign @linuxsuren in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2022
@usernameisnull
Copy link
Contributor Author

/assign @LinuxSuRen

LinuxSuRen
LinuxSuRen reviewed Jun 26, 2022
View reviewed changes
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2022
@LinuxSuRen LinuxSuRen merged commit 04e9d9c into kubesphere:master Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen left review comments

Assignees

@LinuxSuRen LinuxSuRen

Labels
kind/chore lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@usernameisnull @ks-ci-bot @LinuxSuRen