Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the potential jwt secret issues #591

Merged
merged 2 commits into from
May 13, 2022
Merged

Fix the potential jwt secret issues #591

merged 2 commits into from
May 13, 2022

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented May 13, 2022 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

The secret of JWT might be changed randomly potentially due to the error handling issues.

Which issue(s) this PR fixes:

Fixes #507

Special notes for reviewers:

Please check the following list before waiting reviewers:

  • Already committed the CRD files to the Helm Chart if you created some new CRDs
  • Already added the permission for the new API
  • Already added the RBAC markers for the new controllers

Does this PR introduce a user-facing change??

None

@LinuxSuRen
Fix the potential jwt secret issues
388c0db 
Signed-off-by: rick <1450685+LinuxSuRen@users.noreply.github.com>
@ks-ci-bot ks-ci-bot requested a review from a team May 13, 2022 02:35
@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. labels May 13, 2022
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from linuxsuren after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 13, 2022
@LinuxSuRen
Fix the unit test errors
181f029 
Signed-off-by: rick <1450685+LinuxSuRen@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #591 (181f029) into master (7d74557) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #591      +/-   ##
==========================================
- Coverage   77.32%   77.26%   -0.06%     
==========================================
  Files         146      146              
  Lines       23307    23308       +1     
==========================================
- Hits        18021    18010      -11     
- Misses       5072     5083      +11     
- Partials      214      215       +1
Flag Coverage Δ
unittests 77.26% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/tools/jwt/app/jwt_root.go 97.26% <100.00%> (-2.74%) ⬇️
...ns/devopscredential/devopscredential_controller.go 33.33% <0.00%> (-3.41%) ⬇️
.../jenkins/devopsproject/devopsproject_controller.go 40.62% <0.00%> (-2.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d74557...181f029. Read the comment docs.

@LinuxSuRen LinuxSuRen merged commit e6fc32b into kubesphere:master May 13, 2022
@LinuxSuRen LinuxSuRen deleted the fix-jwt-secret branch May 13, 2022 03:20
@LinuxSuRen LinuxSuRen mentioned this pull request May 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The token automatically generated by devOPS -apiserver is unavailable
2 participants
@LinuxSuRen @ks-ci-bot