Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the gitrepository update API cannot change the annotations #532

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Fix the gitrepository update API cannot change the annotations #532

merged 1 commit into from
Apr 2, 2022

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented Apr 2, 2022 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:

/kind bug

Please feel free to use the following image to test it:

kubespheredev/devops-apiserver:dev-v3.2.1-61652d9

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Please check the following list before waiting reviewers:

  • Already committed the CRD files to the Helm Chart if you created some new CRDs
  • Already added the permission for the new API
  • Already added the RBAC markers for the new controllers

Does this PR introduce a user-facing change??

None

@ks-ci-bot ks-ci-bot requested a review from a team April 2, 2022 01:56
@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. labels Apr 2, 2022
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2022
@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #532 (61652d9) into master (c2fefa9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
+ Coverage   77.46%   77.48%   +0.02%     
==========================================
  Files         142      142              
  Lines       23153    23153              
==========================================
+ Hits        17935    17940       +5     
+ Misses       5012     5008       -4     
+ Partials      206      205       -1
Flag Coverage Δ
unittests 77.48% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/kapis/devops/v1alpha3/scm/route.go 100.00% <ø> (ø)
...kapis/devops/v1alpha3/scm/gitrepository_handler.go 94.33% <100.00%> (ø)
...ontrollers/jenkins/pipeline/pipeline_controller.go 43.18% <0.00%> (+3.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2fefa9...61652d9. Read the comment docs.

@LinuxSuRen LinuxSuRen merged commit 591dd17 into kubesphere:master Apr 2, 2022
@LinuxSuRen LinuxSuRen deleted the fix-git-repo-update branch April 2, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinuxSuRen @ks-ci-bot