Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide the ability to filter and sort for applications #506

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Provide the ability to filter and sort for applications #506

merged 2 commits into from
Mar 23, 2022

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Provide the ability to filter and sort for applications. You can see the API doc here:

image

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

/cc @kubesphere/sig-devops

Please check the following list before waiting reviewers:

  • Already committed the CRD files to the Helm Chart if you created some new CRDs
  • Already added the permission for the new API
  • Already added the RBAC markers for the new controllers

Does this PR introduce a user-facing change??

None

@JohnNiang
Provide the ability to filter and sort applications
e45221b 
Signed-off-by: johnniang <johnniang@fastmail.com>
@ks-ci-bot ks-ci-bot requested a review from a team March 22, 2022 09:45
@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 22, 2022
@codecov
Copy link

codecov bot commented Mar 22, 2022 •
edited
Loading

Codecov Report

Merging #506 (159355f) into master (55c2fe3) will decrease coverage by 0.00%.
The diff coverage is 81.57%.

@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
- Coverage   77.66%   77.66%   -0.01%     
==========================================
  Files         139      140       +1     
  Lines       22815    22843      +28     
==========================================
+ Hits        17719    17740      +21     
- Misses       4908     4912       +4     
- Partials      188      191       +3
Flag Coverage Δ
unittests 77.66% <81.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/gitops/v1alpha1/groupversion_info.go 100.00% <ø> (ø)
pkg/apiserver/query/types.go 100.00% <ø> (ø)
...ers/argocd/argocd-application-status-controller.go 74.35% <50.00%> (-6.90%) ⬇️
pkg/kapis/gitops/v1alpha1/argocd/handler.go 95.65% <76.92%> (-4.35%) ⬇️
pkg/kapis/gitops/v1alpha1/argocd/route.go 100.00% <100.00%> (ø)
pkg/kapis/gitops/v1alpha1/argocd/util.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c2fe3...159355f. Read the comment docs.

@JohnNiang
Simplify filter applications by labels
159355f 
Signed-off-by: johnniang <johnniang@fastmail.com>
@ks-ci-bot ks-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 23, 2022
@LinuxSuRen LinuxSuRen added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 23, 2022
LinuxSuRen
LinuxSuRen reviewed Mar 23, 2022
View reviewed changes
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2022
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, LinuxSuRen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2022
@ks-ci-bot ks-ci-bot merged commit daea327 into kubesphere:master Mar 23, 2022
@JohnNiang JohnNiang deleted the feat/application-sort-and-filter branch March 23, 2022 06:17
@JohnNiang JohnNiang mentioned this pull request Mar 25, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen requested changes

Assignees

@LinuxSuRen LinuxSuRen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnNiang @ks-ci-bot @LinuxSuRen