Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required field into template parameter #489

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Add required field into template parameter #489

merged 2 commits into from
Mar 9, 2022

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

As mentioned in the title.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Please check the following list before waiting reviewers:

  • Already committed the CRD files to the Helm Chart if you created some new CRDs
  • Already added the permission for the new API
  • Already added the RBAC markers for the new controllers

Does this PR introduce a user-facing change??

None

@JohnNiang
Add required field into template parameter
6f46b76 
Signed-off-by: johnniang <johnniang@fastmail.com>
@JohnNiang JohnNiang added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 8, 2022
@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2022
@codecov
Copy link

codecov bot commented Mar 8, 2022 •
edited
Loading

Codecov Report

Merging #489 (d85d97e) into master (e56f3b0) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
- Coverage   77.20%   77.16%   -0.05%     
==========================================
  Files         133      133              
  Lines       22756    22757       +1     
==========================================
- Hits        17569    17560       -9     
- Misses       4992     5001       +9     
- Partials      195      196       +1
Flag Coverage Δ
unittests 77.16% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/devops/v1alpha3/template_types.go 50.00% <ø> (+50.00%) ⬆️
...ontrollers/jenkins/pipeline/pipeline_controller.go 39.39% <0.00%> (-3.79%) ⬇️
...ns/devopscredential/devopscredential_controller.go 33.33% <0.00%> (-3.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e56f3b0...d85d97e. Read the comment docs.

@JohnNiang
Copy link
Member Author

/cc @kubesphere/sig-devops

@ks-ci-bot ks-ci-bot requested a review from a team March 8, 2022 07:10
@JohnNiang
Add omitempty on required field
d85d97e 
Signed-off-by: johnniang <johnniang@fastmail.com>
LinuxSuRen
LinuxSuRen reviewed Mar 9, 2022
View reviewed changes
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2022
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, LinuxSuRen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2022
@ks-ci-bot ks-ci-bot merged commit d8e08e8 into kubesphere:master Mar 9, 2022
@JohnNiang JohnNiang mentioned this pull request Mar 10, 2022
Merged
@JohnNiang JohnNiang deleted the feat/add-required-to-template-parameter branch March 10, 2022 06:31
@JohnNiang JohnNiang mentioned this pull request Mar 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen left review comments

Assignees

@LinuxSuRen LinuxSuRen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnNiang @ks-ci-bot @LinuxSuRen