Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new API to download artifacts from a PipelineRun #479

Merged
merged 11 commits into from
Mar 18, 2022
Merged

Create a new API to download artifacts from a PipelineRun #479

merged 11 commits into from
Mar 18, 2022

Conversation

mzmuer
Copy link
Contributor

@mzmuer mzmuer commented Feb 27, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Please refer to: #449

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Please check the following list before waiting reviewers:
An API was created in v1aplha2 : https://github.com/mzmuer/ks-devops/blob/bcdd8765ade8743f65de170238f1e989b92c4955/pkg/kapis/devops/v1alpha2/register.go#L668

Does this PR introduce a user-facing change??

None

@ks-ci-bot ks-ci-bot requested a review from a team February 27, 2022 09:42
@ks-ci-bot ks-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2022
@codecov
Copy link

codecov bot commented Feb 27, 2022 •
edited
Loading

Codecov Report

Merging #479 (0bbe7cd) into master (b617eff) will decrease coverage by 0.07%.
The diff coverage is 40.90%.

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   77.25%   77.18%   -0.08%     
==========================================
  Files         134      134              
  Lines       22874    22916      +42     
==========================================
+ Hits        17671    17687      +16     
- Misses       5006     5032      +26     
  Partials      197      197
Flag Coverage Δ
unittests 77.18% <40.90%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/client/devops/pipeline.go 100.00% <ø> (ø)
pkg/kapis/devops/v1alpha2/devops.go 25.04% <ø> (ø)
pkg/kapis/devops/v1alpha2/register.go 91.80% <ø> (ø)
pkg/kapis/devops/v1alpha3/pipelinerun/handler.go 30.30% <23.52%> (-2.36%) ⬇️
pkg/kapis/devops/v1alpha3/pipelinerun/register.go 100.00% <100.00%> (ø)
pkg/kapis/devops/v1alpha3/register.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b617eff...0bbe7cd. Read the comment docs.

@mzmuer
Copy link
Contributor Author

mzmuer commented Feb 28, 2022

/label tide/merge-method-squash

@ks-ci-bot ks-ci-bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 28, 2022
@mzmuer mzmuer changed the title WIP: create a new API to download artifacts from a PipelineRun create a new API to download artifacts from a PipelineRun Mar 1, 2022
@ks-ci-bot ks-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2022
@JohnNiang
Copy link
Member

/hold
I hold this PR util jenkins-zh/jenkins-client#44 merges. See #479 (comment) for more.

@JohnNiang
Copy link
Member

Hi @mzmuer , I have created a pull request to release Jenkins Client in jenkins-zh/versions#4. After that, you could bump version of Jenkins Client in go.mod to use the artifacts download feature you provided. I hope this will help you.

@ks-ci-bot ks-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2022
JohnNiang
JohnNiang approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2022
LinuxSuRen
LinuxSuRen requested changes Mar 8, 2022
View reviewed changes
pkg/kapis/devops/v1alpha2/register.go Outdated Show resolved Hide resolved
pkg/kapis/devops/v1alpha2/register.go Outdated Show resolved Hide resolved
@mzmuer mzmuer changed the title create a new API to download artifacts from a PipelineRun WIP: create a new API to download artifacts from a PipelineRun Mar 10, 2022
@ks-ci-bot ks-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2022
@mzmuer mzmuer mentioned this pull request Mar 16, 2022
Closed
@ks-ci-bot ks-ci-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 17, 2022
@mzmuer mzmuer changed the title WIP: create a new API to download artifacts from a PipelineRun create a new API to download artifacts from a PipelineRun Mar 17, 2022
@mzmuer mzmuer changed the title create a new API to download artifacts from a PipelineRun WIP: Create a new API to download artifacts from a PipelineRun Mar 17, 2022
@ks-ci-bot ks-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2022
@mzmuer mzmuer force-pushed the feat/download_artifacts branch from 79a1a4c to 63ce3d4 Compare March 17, 2022 07:05
@ks-ci-bot ks-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 17, 2022
@mzmuer
Copy link
Contributor Author

mzmuer commented Mar 17, 2022

Sorry, this git commit issue has been fixed

@mzmuer mzmuer changed the title WIP: Create a new API to download artifacts from a PipelineRun Create a new API to download artifacts from a PipelineRun Mar 17, 2022
@ks-ci-bot ks-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2022
@LinuxSuRen LinuxSuRen mentioned this pull request Mar 17, 2022
Merged
@LinuxSuRen
Copy link
Member

Below is the image of this PR:

kubespheredev/devops-apiserver:dev-v3.2.1-0bbe7cd

LinuxSuRen
LinuxSuRen reviewed Mar 18, 2022
View reviewed changes
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it manually. It works well. Good job @mzmuer

/unhold
/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2022
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen, mzmuer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@JohnNiang JohnNiang merged commit b726b90 into kubesphere:master Mar 18, 2022
@mzmuer mzmuer deleted the feat/download_artifacts branch March 18, 2022 06:40
@LinuxSuRen LinuxSuRen linked an issue May 17, 2022 that may be closed by this pull request
Request to create a new API to download artifacts from a PipelineRun #449
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen requested changes

@JohnNiang JohnNiang JohnNiang requested changes

Assignees

@LinuxSuRen LinuxSuRen

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request to create a new API to download artifacts from a PipelineRun
4 participants
@mzmuer @JohnNiang @LinuxSuRen @ks-ci-bot