Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PipelineRun CRD version to v1alpha3 #238

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Move PipelineRun CRD version to v1alpha3 #238

merged 2 commits into from
Sep 16, 2021

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Sep 16, 2021 •
edited
Loading

What this PR dose

Move PipelineRun type from v1alpha4 to v1alpha3.

Why we need it

Before that, I misunderstood the version of K8s, so I created PipelineRun CRD with version v1alpha4 increasing by existing version v1alpha3. But now, I try to downgrade the PipelineRun CRD version to v1alpha3, which remains the same as other CRDs, like Pipeline, Credential.

References:

Steps to test

  1. Replace PipelineRun CRD
kubectl delete crd pipelineruns.devops.kubesphere.io
kubectl apply -f https://raw.githubusercontent.com/kubesphere/ks-devops/816941e0d4f9c6f0d4784cbe173f9fc8949405dc/config/crd/bases/devops.kubesphere.io_pipelineruns.yaml
  1. Change the docker image of deployment devops-apiserver and devops-controller respectively:
  • johnniang/devops-apiserver:move-pipelinerun-to-v1alpha3
  • johnniang/devops-controller:move-pipelinerun-to-v1alpha3

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JohnNiang
To complete the pull request process, please assign linuxsuren after the PR has been reviewed.
You can assign the PR to them by writing /assign @linuxsuren in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 16, 2021
@JohnNiang
Copy link
Member Author

/cc @kubesphere/sig-devops

@ks-ci-bot ks-ci-bot requested a review from a team September 16, 2021 07:10
@JohnNiang JohnNiang mentioned this pull request Sep 16, 2021
Merged
@codecov
Copy link

codecov bot commented Sep 16, 2021 •
edited
Loading

Codecov Report

Merging #238 (26d31ef) into master (5eaa182) will increase coverage by 0.02%.
The diff coverage is 53.22%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #238      +/-   ##
=========================================
+ Coverage    7.20%   7.22%   +0.02%     
=========================================
  Files          83      83              
  Lines       21118   21112       -6     
=========================================
+ Hits         1521    1525       +4     
+ Misses      19470   19460      -10     
  Partials      127     127
Flag Coverage Δ
unittests 7.22% <53.22%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lers/jenkins/pipelinerun/pipelinerun_controller.go 3.97% <0.00%> (ø)
...i/devops/pipelinerun/v1alpha3/pipelinerun_types.go 6.66% <ø> (ø)
pkg/kapis/devops/v1alpha3/pipelinerun/handler.go 0.00% <0.00%> (ø)
pkg/kapis/devops/v1alpha3/pipelinerun/register.go 0.00% <0.00%> (ø)
pkg/kapis/devops/v1alpha3/pipelinerun/util.go 40.81% <50.00%> (ø)
controllers/jenkins/pipelinerun/utils.go 100.00% <100.00%> (ø)
...devops/v1alpha3/pipelinerun/backwardlisthandler.go 95.83% <100.00%> (ø)
controllers/pipeline/pipeline_controller.go 38.80% <0.00%> (-3.74%) ⬇️
...trollers/devopsproject/devopsproject_controller.go 43.00% <0.00%> (+2.59%) ⬆️
...rs/devopscredential/devopscredential_controller.go 36.48% <0.00%> (+3.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eaa182...26d31ef. Read the comment docs.

LinuxSuRen
LinuxSuRen reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021
@LinuxSuRen LinuxSuRen merged commit 6f81017 into kubesphere:master Sep 16, 2021
@JohnNiang JohnNiang deleted the refactor/move-pipelinerun-to-alphav3 branch September 16, 2021 09:00
This was referenced Sep 16, 2021
Merged
Closed
@LinuxSuRen LinuxSuRen mentioned this pull request Sep 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen left review comments

Assignees

@LinuxSuRen LinuxSuRen

Labels
lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnNiang @ks-ci-bot @LinuxSuRen