Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd/controller cmd/apiserver): remove term which depends on docker library #193

Merged
merged 3 commits into from
Aug 20, 2021
Merged

fix(cmd/controller cmd/apiserver): remove term which depends on docker library #193

merged 3 commits into from
Aug 20, 2021

Conversation

wujiahao15
Copy link
Contributor

@wujiahao15 wujiahao15 commented Aug 18, 2021 •
edited
Loading

resolves #192

@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021 •
edited
Loading

Codecov Report

Merging #193 (f87759e) into master (1c0a472) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #193   +/-   ##
======================================
  Coverage    5.37%   5.37%           
======================================
  Files          75      75           
  Lines       21098   21098           
======================================
  Hits         1135    1135           
  Misses      19890   19890           
  Partials       73      73
Flag Coverage Δ
unittests 5.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 481526e...f87759e. Read the comment docs.

@JohnNiang
Copy link
Member

/lgtm

@ks-ci-bot
Copy link
Collaborator

@JohnNiang: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flamywhale, LinuxSuRen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021
@LinuxSuRen LinuxSuRen merged commit 8c9ec5d into kubesphere:master Aug 20, 2021
@wujiahao15 wujiahao15 deleted the remove-term branch August 20, 2021 07:26
LinuxSuRen pushed a commit that referenced this pull request Aug 22, 2021
@wujiahao15 @LinuxSuRen
fix(cmd/controller cmd/apiserver): remove term which depends on docke…
f4eb2ca 
…r library (#193)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint failed due to outdated package usage of term
5 participants
@wujiahao15 @codecov-commenter @JohnNiang @ks-ci-bot @LinuxSuRen