Add support for archived plugins #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
force-pushed
the
plugin-archive
branch
from
1a69575 to
b513247
Compare
mszostok
commented
Aug 22, 2023
|
|
||
| func main() { | ||
| pluginTargets := flag.String("plugin-targets", getEnv("PLUGIN_TARGETS", ""), "Comma separated list of specific targets to build. If empty, all targets are built.") | ||
| outputMode := flag.String("output-mode", getEnv("OUTPUT_MODE", "archive"), "Output format. Allowed values: binary or archive.") |
There was a problem hiding this comment.
in the next PR I can revert that and bring the default value to binary. However now the OUTPUT_MODE set in the workflow file is ignored so I need to do it in the code instead.
There was a problem hiding this comment.
No, I think it makes sense to have it as default value 👍
mszostok
commented
Aug 22, 2023
| @@ -251,3 +252,7 @@ jobs: | |||
| run: | | |||
| KUBECONFIG=$(k3d kubeconfig write ${{ matrix.integration }}-test-cluster) \ | |||
| make test-integration-${{ matrix.integration }} | |||
|
|
|||
| - name: Dump cluster | |||
There was a problem hiding this comment.
I can add the same in other places, WDYT?
pkosiec
approved these changes
Aug 22, 2023
|
|
||
| func main() { | ||
| pluginTargets := flag.String("plugin-targets", getEnv("PLUGIN_TARGETS", ""), "Comma separated list of specific targets to build. If empty, all targets are built.") | ||
| outputMode := flag.String("output-mode", getEnv("OUTPUT_MODE", "archive"), "Output format. Allowed values: binary or archive.") |
There was a problem hiding this comment.
No, I think it makes sense to have it as default value 👍
mszostok
force-pushed
the
plugin-archive
branch
from
c24d003 to
fc1655e
Compare
mszostok
force-pushed
the
plugin-archive
branch
2 times, most recently
from
3613d44 to
c8d4e6c
Compare
mszostok
force-pushed
the
plugin-archive
branch
from
c8d4e6c to
52a25b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Testing
Integration test are already using archives. However, you can test that also locally by running botkube with local plugins in the same way as you did before.
Related issue(s)