Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAS: Assign only hostname values to TopologyAssignment #3677

Merged
merged 2 commits into from
Nov 29, 2024
Merged

TAS: Assign only hostname values to TopologyAssignment #3677

merged 2 commits into from
Nov 29, 2024

Conversation

PBundyra
Copy link
Contributor

@PBundyra PBundyra commented Nov 28, 2024 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Assign only hostname values to TopologyAssignment is a user defines kubernetes.io/hostname in the Topology object

Which issue(s) this PR fixes:

Fixes #3671

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Optimize the size of the Workload object when Topology-Aware Scheduling is used, and the 
`kubernetes.io/hostname` is defined as the lowest Topology level. In that case the `TopologyAssignment`
in the Workload's Status contains value only for this label, rather than for all levels defined.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 28, 2024
@PBundyra
Copy link
Contributor Author

/assign @mimowo

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 28, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 28, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 39fc4de
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67498a8a419b220008129fba

mimowo
mimowo reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, but generally looking good

apis/kueue/v1beta1/workload_types.go Outdated Show resolved Hide resolved
pkg/cache/tas_flavor_snapshot.go Outdated Show resolved Hide resolved
@PBundyra
Copy link
Contributor Author

/retest

mimowo
mimowo reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two nits

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2024
@PBundyra
Keep only k8s values in TopologyAssignment if the topology defines ho…
c9058d9 
…stname label

Update KEP and docs

Fix tests, fix doc

Update doc, commonize code

Update e2e test
@PBundyra PBundyra force-pushed the optimize-topology-assignment branch from d1bfa46 to 989dd48 Compare November 29, 2024 09:15
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2024
@PBundyra PBundyra force-pushed the optimize-topology-assignment branch from 989dd48 to 39fc4de Compare November 29, 2024 09:34
mimowo
mimowo reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa7c8ee8ae03bd60fecff6543b4f41940f0965e5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, PBundyra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 59ef4b7 into kubernetes-sigs:main Nov 29, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.10 milestone Nov 29, 2024
@mimowo
Copy link
Contributor

mimowo commented Nov 29, 2024 •
edited
Loading

Proposal emphasizing the user-gain (optimized Workload size) , and that kubernetes.io/hostname needs to be at the lowest level.
/release-note-edit

Optimize the size of the Workload object when Topology-Aware Scheduling is used, and the 
`kubernetes.io/hostname` is defined as the lowest Topology level. In that case the `TopologyAssignment`
in the Workload's Status contains value only for this label, rather than for all levels defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.

TAS: Optimize Workload object size by listing only hostname values in .status.TopologyAssignment field
3 participants
@PBundyra @k8s-ci-robot @mimowo