Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAS: fix scenario when parallelism < completions #3559

Merged
merged 1 commit into from
Nov 15, 2024
Merged

TAS: fix scenario when parallelism < completions #3559

merged 1 commit into from
Nov 15, 2024

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Nov 15, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #3450

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix running Job when parallelism < completions, before the fix the replacement pods for the successfully
completed Pods were not ungated.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Nov 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 15, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit f126604
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6737a67f0e59d2000838d29b

@mimowo mimowo force-pushed the tas-fix-for-completions branch from 9042d03 to f126604 Compare November 15, 2024 19:52
@mbobrovskyi
Copy link
Contributor

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b158606c1b7d5911f2412487e32c3dbcaba3b450

@k8s-ci-robot k8s-ci-robot merged commit 30da293 into kubernetes-sigs:main Nov 15, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.10 milestone Nov 15, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Nov 15, 2024

/cherry-pick release-0.9

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: #3559 failed to apply on top of branch "release-0.9":

Applying: TAS: fix scenario when parallelism < completions
Using index info to reconstruct a base tree...
M	pkg/controller/tas/topology_ungater.go
A	test/e2e/tas/tas_test.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): test/e2e/tas/tas_test.go deleted in HEAD and modified in TAS: fix scenario when parallelism < completions. Version TAS: fix scenario when parallelism < completions of test/e2e/tas/tas_test.go left in tree.
Auto-merging pkg/controller/tas/topology_ungater.go
CONFLICT (content): Merge conflict in pkg/controller/tas/topology_ungater.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 TAS: fix scenario when parallelism < completions

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mimowo mimowo mentioned this pull request Nov 18, 2024
Merged
kannon92 pushed a commit to kannon92/kueue that referenced this pull request Dec 5, 2024
@mimowo @kannon92
TAS: fix scenario when parallelism < completions (kubernetes-sigs#3559)
40ce6be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbobrovskyi mbobrovskyi mbobrovskyi left review comments

@denkensk denkensk Awaiting requested review from denkensk

@trasc trasc Awaiting requested review from trasc

Assignees

@mbobrovskyi mbobrovskyi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.
4 participants
@mimowo @k8s-ci-robot @mbobrovskyi @k8s-infra-cherrypick-robot