Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate QueueVisibility feature and corresponding API. #3110

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Deprecate QueueVisibility feature and corresponding API. #3110

merged 1 commit into from
Sep 24, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Sep 23, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Deprecate QueueVisibility feature and corresponding API.

Which issue(s) this PR fixes:

Fixes #2256

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The QueueVisibility feature and its corresponding API was deprecated.

ACTION REQUIRED: The QueueVisibility feature and its corresponding API was deprecated and will be removed in the v1beta2. Please use VisibilityOnDemand (https://kueue.sigs.k8s.io/docs/tasks/manage/monitor_pending_workloads/pending_workloads_on_demand/) instead.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 23, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 23, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 23, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit c03240b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66f2e8ba6214f100082bb831
😎 Deploy Preview https://deploy-preview-3110--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi mbobrovskyi force-pushed the feature/deprecate-the-queue-visibility-feature-gate-and-corresponding-api branch 2 times, most recently from 5001587 to 777e2d1 Compare September 23, 2024 08:53
@mbobrovskyi mbobrovskyi marked this pull request as ready for review September 23, 2024 08:54
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@k8s-ci-robot k8s-ci-robot requested a review from mimowo September 23, 2024 08:54
@mbobrovskyi mbobrovskyi changed the title Deprecate QueueVisibility feature. Deprecate QueueVisibility feature and corresponding API. Sep 23, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 23, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/deprecate-the-queue-visibility-feature-gate-and-corresponding-api branch from 777e2d1 to 57de77b Compare September 23, 2024 09:05
@mbobrovskyi
Copy link
Contributor Author

/hold for #3112.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/deprecate-the-queue-visibility-feature-gate-and-corresponding-api branch from 57de77b to 5d97942 Compare September 23, 2024 11:06
@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 24, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/deprecate-the-queue-visibility-feature-gate-and-corresponding-api branch from 5d97942 to f808838 Compare September 24, 2024 16:13
tenzen-y
tenzen-y reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c982c52d7239fb8e6fc23b79f60d0892ee414c25

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2024
@mbobrovskyi
Copy link
Contributor Author

/unhold

Due to #3112 merged.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/deprecate-the-queue-visibility-feature-gate-and-corresponding-api branch from f808838 to c03240b Compare September 24, 2024 16:28
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2024
tenzen-y
tenzen-y reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 83ffdc5be7c6880e97877ba620eb23579b272203

@mbobrovskyi
Copy link
Contributor Author

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot merged commit 81ca4dc into kubernetes-sigs:main Sep 24, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Sep 24, 2024
@mbobrovskyi mbobrovskyi deleted the feature/deprecate-the-queue-visibility-feature-gate-and-corresponding-api branch September 24, 2024 16:50
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@mbobrovskyi @kannon92
Deprecate the QueueVisibility feature gate and corresponding API. (ku…
cb21479 
…bernetes-sigs#3110)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@trasc trasc Awaiting requested review from trasc

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.

Deprecate the QueueVisibility feature gate and corresponding API
3 participants
@mbobrovskyi @k8s-ci-robot @tenzen-y