Move openapi to visibility directory. #3083
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/XS
|
/cc @mimowo |
|
I synced with @mbobrovskyi who tested e2e manually that it works after merging the openapi generation for alpha and beta. This approach is also used by kube-aggregator as pointed out by Mike: https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kube-aggregator/pkg/generated/openapi/zz_generated.openapi.go I think it makes sense, but would like to have another pair of eyes. |
|
LGTM |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 6c1e931e5c619df06fdbe614c516a0f5b3e265f0
|
k8s-ci-robot
added
the
approved
mbobrovskyi
deleted the
cleanup/move-openapi-to-visibility-directory
branch
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Move openapi to visibility directory. It will allow us to use it on both visibility API versions v1alpha1 and v1beta1.
Which issue(s) this PR fixes:
Prepare for #2973
Special notes for your reviewer:
Does this PR introduce a user-facing change?