Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Remove internal tools dependency on relative path #3076

Merged
merged 7 commits into from
Sep 18, 2024
Merged

[Cleanup] Remove internal tools dependency on relative path #3076

merged 7 commits into from
Sep 18, 2024

Conversation

mszadkow
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Dependabot suggests updates that are incompatible with internal tools, replaced version.

Which issue(s) this PR fixes:

Fixes #3062

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 17, 2024
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 17, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 2e2fba7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66e98a17c7ed710007f03bfa
😎 Deploy Preview https://deploy-preview-3076--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi
Copy link
Contributor

We also need to fix it for kjobctl.

@mszadkow
Copy link
Contributor Author

We also need to fix it for kjobctl.

I see, thanks

@mszadkow
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 17, 2024
@mszadkow
Copy link
Contributor Author

/retest-required

@mszadkow
Run go mod tidy on kjobctl
3480b14 
Apply verify changes
@mszadkow
Copy link
Contributor Author

/retest-required

mbobrovskyi
mbobrovskyi reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@mbobrovskyi mbobrovskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you generate docs for kjobctl?

cmd/kueuectl-docs/templates/main.html Outdated Show resolved Hide resolved
@mszadkow
Copy link
Contributor Author

Did you generate docs for kjobctl?

I run both kjobctl generate targets

@mbobrovskyi
Copy link
Contributor

Did you generate docs for kjobctl?

I run both kjobctl generate targets

It's strange that it doesn't regenerate docs for kjobctl.

@mszadkow
Copy link
Contributor Author

/retest

@mszadkow
Copy link
Contributor Author

Did you generate docs for kjobctl?

I run both kjobctl generate targets

It's strange that it doesn't regenerate docs for kjobctl.

I found my mistake, they are regenerated rn

@mbobrovskyi
Copy link
Contributor

mbobrovskyi commented Sep 17, 2024 •
edited
Loading

And also it's strange that test didn't show error.

UPDATE: Ah, I see why it's happens.

@mbobrovskyi
Copy link
Contributor

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 48ff348892dd166efb02bf40e564b23eaa379abd

@mszadkow mszadkow marked this pull request as ready for review September 18, 2024 06:37
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@mimowo
Copy link
Contributor

mimowo commented Sep 18, 2024

/approve
Awesome, thank you for working on it. I guess the best was to test will be to see the new wave of PRs :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, mszadkow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit f6d2271 into kubernetes-sigs:main Sep 18, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Sep 18, 2024
@mbobrovskyi mbobrovskyi deleted the cleanup/dependabot-prs-failing branch September 18, 2024 16:57
@tenzen-y tenzen-y mentioned this pull request Sep 27, 2024
Merged
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@mszadkow @kannon92
[Cleanup] Remove internal tools dependency on relative path (kubernet…
f140812 
…es-sigs#3076)

* Move kueuectl-docs to cmd

* Regenerate docs

* Move kjobctl-docs to cmd and kjobctl to separate folder

* More re-generated files

* Run go mod tidy

* Run go mod tidy on kjobctl

Apply verify changes

* Fix template path and regenerate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbobrovskyi mbobrovskyi mbobrovskyi left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@trasc trasc Awaiting requested review from trasc

@denkensk denkensk Awaiting requested review from denkensk

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@mbobrovskyi mbobrovskyi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.

PRs opened by dependabot for /hack/internal/tools fail for non-breaking changes
4 participants
@mszadkow @k8s-ci-robot @mbobrovskyi @mimowo