Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump github.com/ray-project/kuberay/ray-operator from 1.1.1 to 1.2.1. #2960

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Bump github.com/ray-project/kuberay/ray-operator from 1.1.1 to 1.2.1. #2960

merged 1 commit into from
Sep 2, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Sep 2, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bump github.com/ray-project/kuberay/ray-operator from 1.1.1 to 1.2.1.

Which issue(s) this PR fixes:

Part of #2878

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix support for kuberay 1.2.x

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 2, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 2, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 2, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit c4a5280
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66d59cd12c90b7000832ce79

@mbobrovskyi mbobrovskyi force-pushed the cleanup/bump-ray-operator-from-1.1.1-to-1.2.1 branch from 943a304 to 145384d Compare September 2, 2024 11:02
@mbobrovskyi mbobrovskyi force-pushed the cleanup/bump-ray-operator-from-1.1.1-to-1.2.1 branch from 145384d to c4a5280 Compare September 2, 2024 11:09
@mbobrovskyi
Copy link
Contributor Author

/cc @mimowo

@k8s-ci-robot k8s-ci-robot requested a review from mimowo September 2, 2024 11:25
@mbobrovskyi mbobrovskyi mentioned this pull request Sep 2, 2024
Closed
@mimowo
Copy link
Contributor

mimowo commented Sep 2, 2024

/lgtm
/approve
/hold
Do you know and could summarize what was the issue with the original PR?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9d6ccabe8a89cbaa9226c0b638673fd1eb9d8185

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2024
@mbobrovskyi
Copy link
Contributor Author

Do you know and could summarize what was the issue with the original PR?

Yes, sure. It happens due to conflict of versions.

In original PR is using github.com/prometheus/client_golang v1.19.1 and github.com/prometheus/common v0.54.0.
With this version I had an error:

could not import k8s.io/component-base/metrics/testutil (-: # k8s.io/component-base/metrics/testutil
vendor/k8s.io/component-base/metrics/testutil/metrics.go:73:59: undefined: expfmt.FmtText)

I have updated this dependencies to github.com/prometheus/client_golang v1.20.2 and github.com/prometheus/common v0.57.0 to fix it.

@mimowo
Copy link
Contributor

mimowo commented Sep 2, 2024

Awesome, thanks!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6df7d2f into kubernetes-sigs:main Sep 2, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Sep 2, 2024
@mbobrovskyi mbobrovskyi deleted the cleanup/bump-ray-operator-from-1.1.1-to-1.2.1 branch September 2, 2024 11:55
@mbobrovskyi mbobrovskyi mentioned this pull request Sep 4, 2024
Closed
@tenzen-y
Copy link
Member

tenzen-y commented Sep 4, 2024

Let's cherry-pick this PR so that users can use the latest KubeRay.

/cherry-pick release-0.8

@k8s-infra-cherrypick-robot
Copy link
Contributor

@tenzen-y: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked.

Error messagestatus code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of lines (20000)","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#get-a-pull-request","status":"406"}

In response to this:

Let's cherry-pick this PR so that users can use the latest KubeRay.

/cherry-pick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alculquicondor
Copy link
Contributor

@mbobrovskyi can you prepare the cherry-pick?

@mbobrovskyi mbobrovskyi mentioned this pull request Sep 4, 2024
Merged
@alculquicondor
Copy link
Contributor

/release-note-edit

Fix support for kube-ray 1.2.x

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 4, 2024
@alculquicondor
Copy link
Contributor

/release-note-edit

Fix support for kuberay 1.2.x

@andrewsykim
Copy link
Member

thanks folks!

@mimowo
Copy link
Contributor

mimowo commented Oct 4, 2024

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 4, 2024
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@mbobrovskyi @kannon92
Bump github.com/ray-project/kuberay/ray-operator from 1.1.1 to 1.2.1. (…
4d241ad 
…kubernetes-sigs#2960)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@denkensk denkensk Awaiting requested review from denkensk

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.
7 participants
@mbobrovskyi @mimowo @k8s-ci-robot @tenzen-y @k8s-infra-cherrypick-robot @alculquicondor @andrewsykim