Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release notes to the body of the pull request on create cherry-pick. #2884

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Add release notes to the body of the pull request on create cherry-pick. #2884

merged 1 commit into from
Aug 27, 2024

Conversation

mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Add release notes to the body of the pull request on create cherry-pick.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 23, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 23, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 23, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit c7ea617
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66c8ff3e385eeb000811d1b1
😎 Deploy Preview https://deploy-preview-2884--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi
Copy link
Contributor Author

/cc @tenzen-y

@k8s-ci-robot k8s-ci-robot requested a review from tenzen-y August 23, 2024 21:39
@mbobrovskyi
Copy link
Contributor Author

mbobrovskyi commented Aug 23, 2024 •
edited
Loading

/retest

Due to #2885.

@mbobrovskyi
Copy link
Contributor Author

/cc @alculquicondor

@tenzen-y
Copy link
Member

TBH, I would like to work on the script improvement at k/k before we move this forward.
I would like to keep using the same script as the k/k one.

@mbobrovskyi
Copy link
Contributor Author

TBH, I would like to work on the script improvement at k/k before we move this forward. I would like to keep using the same script as the k/k one.

I think it's a good idea! I will create PR on k/k. Thanks.

tenzen-y
tenzen-y reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are approved at kubernetes/kubernetes#126925.
@mbobrovskyi So, could you align only with approved changes?

@mbobrovskyi
Copy link
Contributor Author

These changes are approved at kubernetes/kubernetes#126925. @mbobrovskyi So, could you align only with approved changes?

Yes, that what we have. Only difference with Copyright year.

tenzen-y
tenzen-y reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cba1b9aadbac4e8d5f81caa06b47a995402cf627

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit c257cc0 into kubernetes-sigs:main Aug 27, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Aug 27, 2024
@mbobrovskyi mbobrovskyi deleted the fix/add-release-note-on-cherry-pick branch August 27, 2024 04:27
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@mbobrovskyi @kannon92
Add release notes to the body of the pull request on create cherry-pi…
b5344eb 
…ck. (kubernetes-sigs#2884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@denkensk denkensk Awaiting requested review from denkensk

@mimowo mimowo Awaiting requested review from mimowo

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.
3 participants
@mbobrovskyi @tenzen-y @k8s-ci-robot