Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Kubernetes dependencies to v0.31.x #2402

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Bump Kubernetes dependencies to v0.31.x #2402

merged 3 commits into from
Sep 12, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Jun 12, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Bump Kubernetes dependencies to v0.31.x.

Which issue(s) this PR fixes:

Fixes #2948

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support for Kubernetes 1.31

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 12, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 12, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 4f0badd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66e2dab56b0e0f0008038434

@mbobrovskyi mbobrovskyi changed the title Move kube-codegen to local dependencies. Move kube-codegen to internal dependencies. Jun 12, 2024
@mbobrovskyi
Copy link
Contributor Author

/test all

@mbobrovskyi mbobrovskyi force-pushed the cleanup/update-kube-codegen-version branch from d121510 to 5eac066 Compare June 12, 2024 07:14
@mbobrovskyi
Copy link
Contributor Author

/test pull-kueue-verify-main

@mbobrovskyi mbobrovskyi force-pushed the cleanup/update-kube-codegen-version branch from 5eac066 to f2f77ef Compare June 12, 2024 14:08
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2024
@mbobrovskyi mbobrovskyi force-pushed the cleanup/update-kube-codegen-version branch from f2f77ef to f990eb3 Compare June 12, 2024 14:14
This was referenced Jun 13, 2024
Closed
Merged
@mbobrovskyi mbobrovskyi force-pushed the cleanup/update-kube-codegen-version branch from f990eb3 to b22ed36 Compare June 26, 2024 05:23
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 26, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2024
@mbobrovskyi mbobrovskyi force-pushed the cleanup/update-kube-codegen-version branch 2 times, most recently from 1c1dbbc to 2ed557b Compare August 14, 2024 21:41
@mbobrovskyi
Copy link
Contributor Author

/test all

@mbobrovskyi mbobrovskyi changed the title Move kube-codegen to internal dependencies. Bump kube-codegen version. Aug 14, 2024
@mbobrovskyi mbobrovskyi changed the title Bump kube-codegen version. Bump k8s.io/code-generator from v0.29.7 to v0.31.0. Aug 14, 2024
@mbobrovskyi mbobrovskyi force-pushed the cleanup/update-kube-codegen-version branch from 2ed557b to b0a2c18 Compare August 14, 2024 21:56
@mbobrovskyi mbobrovskyi marked this pull request as ready for review August 14, 2024 21:56
@kannon92
Copy link
Contributor

kannon92 commented Sep 3, 2024

Can you add 1.31 to the E2E_K8S_VERSION in Makefile-test.mk?

@mbobrovskyi
Copy link
Contributor Author

Can you add 1.31 to the E2E_K8S_VERSION in Makefile-test.mk?

Good point, thanks!

@mbobrovskyi mbobrovskyi force-pushed the cleanup/update-kube-codegen-version branch 2 times, most recently from fa6a109 to b9a6493 Compare September 3, 2024 20:39
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
@mbobrovskyi mbobrovskyi mentioned this pull request Sep 9, 2024
Closed
@mbobrovskyi mbobrovskyi force-pushed the cleanup/update-kube-codegen-version branch from b9a6493 to 3bab052 Compare September 9, 2024 11:27
@kannon92
Copy link
Contributor

1.31.1 was released. Can you rebase this and get this in?

@mbobrovskyi mbobrovskyi force-pushed the cleanup/update-kube-codegen-version branch from 3bab052 to 0a13130 Compare September 12, 2024 12:02
@mimowo
Copy link
Contributor

mimowo commented Sep 12, 2024 •
edited
Loading

Is this just a cleanup though? I think it deserves a release note, as it has user-facing consequences - it fixes #2948, and allows support for JobSet 0.6.0 .

Tentatively updating, but feel free to change / discuss if I'm missing something. We can mention the support for JobSet 0.6 in the follow up PR updating JobSet.

/kind feature
/release-note-edit

Support for Kubernetes 1.31

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 12, 2024
@mbobrovskyi
Copy link
Contributor Author

mbobrovskyi commented Sep 12, 2024 •
edited
Loading

Yeah, it started as a small cleanup for the code-generator and ended up as a major feature to support Kubernetes 1.31 :)

@mbobrovskyi
Copy link
Contributor Author

/hold cancel

Due to first patch for k8s dependencies released.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2024
@mimowo
Copy link
Contributor

mimowo commented Sep 12, 2024 •
edited
Loading

Please also add "Fixes #2948" in the description. I know this issue is closed already, but I think it will make the relationship easier to discover for future readers who find the PR in the release-notes.

@alculquicondor
Copy link
Contributor

/remove-kind cleanup

@k8s-ci-robot k8s-ci-robot removed the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 12, 2024
@alculquicondor
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e14448fd7c8aaf840769d0c52e96ca6330f37f3e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mbobrovskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c03277c into kubernetes-sigs:main Sep 12, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Sep 12, 2024
@mbobrovskyi mbobrovskyi deleted the cleanup/update-kube-codegen-version branch September 12, 2024 14:26
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@mbobrovskyi @kannon92
Bump Kubernetes dependencies to v0.31.x (kubernetes-sigs#2402)
1d0746c 
* Bump kubernetes dependencies to v0.31.x.

* Use Kubernetes v1.31.0 on tests.

* Bump kubernetes dependencies to v0.31.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo Awaiting requested review from mimowo

@trasc trasc Awaiting requested review from trasc

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.

Pods lose 1.31 fields during creation
6 participants
@mbobrovskyi @k8s-ci-robot @tenzen-y @kannon92 @mimowo @alculquicondor