Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare the versions of tools allowing for updates by dependabot #2334

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Declare the versions of tools allowing for updates by dependabot #2334

merged 1 commit into from
Jun 4, 2024

Conversation

mszadkow
Copy link
Contributor

@mszadkow mszadkow commented May 31, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Move the declaration of version of the tools from make to go.mod

Which issue(s) this PR fixes:

Fixes #2284

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 31, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mszadkow. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 31, 2024
@netlify Netlify
Copy link

netlify bot commented May 31, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit c90bceb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6659dc134871870008436fa4

@mbobrovskyi
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2024
@mszadkow mszadkow force-pushed the cleanup/move-tools-version-to-mod branch from f97ef52 to 9717ef5 Compare May 31, 2024 13:09
mbobrovskyi
mbobrovskyi reviewed May 31, 2024
View reviewed changes
hack/internal/tools/pinversion.go Outdated
@@ -23,4 +23,19 @@ import (
// we need to reference individual dependencies used by it
_ "sigs.k8s.io/controller-tools/pkg/crd"
_ "sigs.k8s.io/controller-tools/pkg/genall/help/pretty"

Copy link
Contributor

@mbobrovskyi mbobrovskyi May 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this unnecessary space?

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 31, 2024
@mszadkow mszadkow force-pushed the cleanup/move-tools-version-to-mod branch from 9717ef5 to e194a99 Compare May 31, 2024 13:34
@mbobrovskyi
Copy link
Contributor

/test all

@mszadkow mszadkow force-pushed the cleanup/move-tools-version-to-mod branch from e194a99 to c90bceb Compare May 31, 2024 14:17
@mbobrovskyi
Copy link
Contributor

/retest

@mbobrovskyi
Copy link
Contributor

mbobrovskyi commented Jun 3, 2024 •
edited
Loading

LGTM

/assign @trasc

@mszadkow mszadkow marked this pull request as ready for review June 3, 2024 06:37
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2024
@k8s-ci-robot k8s-ci-robot requested a review from trasc June 3, 2024 06:37
tenzen-y
tenzen-y reviewed Jun 3, 2024
View reviewed changes
Makefile-deps.mk

HELM = $(PROJECT_DIR)/bin/helm
.PHONY: helm
helm: ## Download helm locally if necessary.
@GOBIN=$(PROJECT_DIR)/bin GO111MODULE=on $(GO_CMD) install helm.sh/helm/v3/cmd/helm@v3.12.1
@GOBIN=$(PROJECT_DIR)/bin GO111MODULE=on $(GO_CMD) install helm.sh/helm/v3/cmd/helm@$(HELM_VERSION)

GENREF = $(PROJECT_DIR)/bin/genref
.PHONY: genref
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we manage the genref as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

genref is a main package it cannot be added in go.mod

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly it's module/command and not a package or something that can be imported :( https://pkg.go.dev/github.com/kubernetes-sigs/reference-docs/genref

@trasc trasc mentioned this pull request Jun 4, 2024
Closed
trasc
trasc reviewed Jun 4, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b6ea08e92b1b1d9d203be65891593b21accc14a6

@alculquicondor
Copy link
Contributor

/approve

We can split into a separate gomodule in a follow up.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mszadkow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4a650e0 into kubernetes-sigs:main Jun 4, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Jun 4, 2024
@dgrove-oss dgrove-oss mentioned this pull request Jun 4, 2024
Closed
@mszadkow mszadkow deleted the cleanup/move-tools-version-to-mod branch June 5, 2024 08:23
@mszadkow mszadkow mentioned this pull request Jun 21, 2024
Closed
11 tasks
Fiona-Waters pushed a commit to Fiona-Waters/kueue that referenced this pull request Jun 25, 2024
@mszadkow @Fiona-Waters
Allow dependabot to manage tools version (kubernetes-sigs#2334)
bcd9eec
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@mszadkow @kannon92
Allow dependabot to manage tools version (kubernetes-sigs#2334)
b507c6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@trasc trasc trasc left review comments

@mbobrovskyi mbobrovskyi mbobrovskyi left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

Declare the versions of tools allowing for updates by dependabot
6 participants
@mszadkow @k8s-ci-robot @mbobrovskyi @alculquicondor @trasc @tenzen-y