-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lint issues reported by gocritic #2000
Fix lint issues reported by gocritic #2000
Conversation
Hi @alexandear. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: faa8f3ca107ee16e6b6b59a4c01fdabb7260bfd3
|
/ok-to-test |
test/integration/controller/jobs/jobset/jobset_controller_test.go
Outdated
Show resolved
Hide resolved
431044e
to
0508214
Compare
0508214
to
9f8a95a
Compare
9f8a95a
to
d1c5e06
Compare
/lgtm |
LGTM label has been added. Git tree hash: f530b480cfec0b235ba517bbf9bf4193eadd2753
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexandear, mimowo, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alexandear please fix the verify |
d1c5e06
to
6833799
Compare
@mimowo fixed. The failure occurred because new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 5a5c9c21eab77d918986b5cf0ac70ef4bbfc8717
|
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fixes
gocritic
lint issues:assignOp
,captLocal
,commentFormatting
,elseif
,ifElseChain
.Which issue(s) this PR fixes:
Special notes for your reviewer:
Follows #1946. See also https://github.com/kubernetes-sigs/kueue/pull/1946/files#r1552980330
Full log
Does this PR introduce a user-facing change?