Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: variables renaming #185

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Cleanup: variables renaming #185

merged 1 commit into from
Apr 7, 2022

Conversation

ahg-g
Copy link
Contributor

@ahg-g ahg-g commented Apr 7, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

variables renaming for consistency

Which issue(s) this PR fixes:

Fixes #

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 7, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 7, 2022
@ahg-g ahg-g mentioned this pull request Apr 7, 2022
Merged
ArangoGutierrez
ArangoGutierrez approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, ArangoGutierrez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahg-g ahg-g changed the title cleanup: variables renaming Cleanup: variables renaming Apr 7, 2022
@ArangoGutierrez
Copy link
Contributor

/assign alculquicondor

@ArangoGutierrez ArangoGutierrez removed their assignment Apr 7, 2022
@alculquicondor
Copy link
Contributor

not so sure about this one, maybe we should name all the booleans admissible.

otherwise you run into double-negative situations inadmissible = false, which can be confusing.

denkensk
denkensk reviewed Apr 7, 2022
View reviewed changes
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
@ahg-g
Copy link
Contributor Author

ahg-g commented Apr 7, 2022

ok, lets use admissible for the boolean and inadmissibleMessage for the message

@alculquicondor
Copy link
Contributor

I was suggesting in the other PR that we use admitted and inadmissibleMessage

@ahg-g
Copy link
Contributor Author

ahg-g commented Apr 7, 2022

I was suggesting in the other PR that we use admitted and inadmissibleMessage

during nominate, it would only be admissible not admitted.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2022
alculquicondor
alculquicondor reviewed Apr 7, 2022
View reviewed changes
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
alculquicondor
alculquicondor reviewed Apr 7, 2022
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
squash?

@ahg-g
Copy link
Contributor Author

ahg-g commented Apr 7, 2022

LGTM squash?

done

@alculquicondor
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2022
@ahg-g
Copy link
Contributor Author

ahg-g commented Apr 7, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit be43d70 into kubernetes-sigs:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denkensk denkensk denkensk left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahg-g @k8s-ci-robot @ArangoGutierrez @alculquicondor @denkensk