Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added security insight #1469

Merged
merged 10 commits into from
Dec 19, 2023
Merged

Added security insight #1469

merged 10 commits into from
Dec 19, 2023

Conversation

ashish493
Copy link
Contributor

What type of PR is this?

Signed-off-by: Ashish Malik malikashish493@gmail.com
#SecuritySlam

What this PR does / why we need it:

This PR adds security insights yml file

Which issue(s) this PR fixes:

This commit is part of the December 2023 Security Slam.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 15, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 15, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit fba7042
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6580a42fccb6b10008240ad0

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 15, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @ashish493!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 15, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @ashish493. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 15, 2023
@psschwei psschwei mentioned this pull request Dec 15, 2023
Closed
@ArangoGutierrez
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 15, 2023
@ArangoGutierrez
Copy link
Contributor

#SecuritySlam @puerco
/sig release

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Dec 15, 2023
@ashish493 ashish493 force-pushed the docs/security-insights branch from 9c8fa84 to 0101fc2 Compare December 15, 2023 21:18
ArangoGutierrez
ArangoGutierrez suggested changes Dec 15, 2023
View reviewed changes
SECURITY-INSIGHTS.yml Outdated Show resolved Hide resolved
SECURITY-INSIGHTS.yml Outdated Show resolved Hide resolved
@ashish493 ashish493 force-pushed the docs/security-insights branch from 0101fc2 to 85bb71e Compare December 15, 2023 21:20
ArangoGutierrez
ArangoGutierrez suggested changes Dec 15, 2023
View reviewed changes
SECURITY-INSIGHTS.yml Outdated Show resolved Hide resolved
ArangoGutierrez
ArangoGutierrez suggested changes Dec 15, 2023
View reviewed changes
SECURITY-INSIGHTS.yml Outdated Show resolved Hide resolved
@psschwei psschwei mentioned this pull request Dec 15, 2023
Open
alculquicondor
alculquicondor reviewed Dec 15, 2023
View reviewed changes
SECURITY-INSIGHTS.yml Outdated Show resolved Hide resolved
SECURITY-INSIGHTS.yml Outdated Show resolved Hide resolved
SECURITY-INSIGHTS.yml Outdated Show resolved Hide resolved
@ArangoGutierrez
Copy link
Contributor

/test pull-kueue-test-integration-main

@ArangoGutierrez
Copy link
Contributor

/assign

ArangoGutierrez
ArangoGutierrez approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 673d24123d1d4d416da698b2625466c637c2b951

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2023
@ashish493 ashish493 force-pushed the docs/security-insights branch from c841415 to ab82923 Compare December 18, 2023 19:40
tenzen-y
tenzen-y reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

.github/ISSUE_TEMPLATE/NEW_RELEASE.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, ashish493, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@tenzen-y
Copy link
Member

/assign @ArangoGutierrez

@ashish493 @tenzen-y
Update .github/ISSUE_TEMPLATE/NEW_RELEASE.md
fba7042 
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@ashish493
Copy link
Contributor Author

/test pull-kueue-test-integration-main

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2023
@tenzen-y
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9bf0c7ceb9955d92abd38d6617afea322871514d

@tenzen-y
Copy link
Member

Due to #1484
/test pull-kueue-test-integration-main

@k8s-ci-robot k8s-ci-robot merged commit 5fced9e into kubernetes-sigs:main Dec 19, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Dec 19, 2023
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@ashish493 @psschwei
@Gephrie @ArangoGutierrez @tenzen-y @kannon92
Added security insight (kubernetes-sigs#1469)
1339d26 
* Added security insight

Co-authored-by: Paul S. Schweigert <paul@paulschweigert.com>
Co-authored-by: Jeff Bailey <bailey.jeff@live.com>

* Updated NEW_RELEASE.md to include security insights release version

* Update SECURITY-INSIGHTS.yml

Co-authored-by: Carlos Eduardo Arango Gutierrez <arangogutierrez@gmail.com>

* Replaced yml with yaml and updated last-updated date

* Replaced security contacts with group mail

* Resolved conflicts

* Replaced old values in NEW_RELEASE.md

* updated points with identation NEW_RELEASE.md

* Added distribution points in SECURITY-INSIGHTS.yaml

* Update .github/ISSUE_TEMPLATE/NEW_RELEASE.md

Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

---------

Co-authored-by: Paul S. Schweigert <paul@paulschweigert.com>
Co-authored-by: Jeff Bailey <bailey.jeff@live.com>
Co-authored-by: Carlos Eduardo Arango Gutierrez <arangogutierrez@gmail.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@kerthcet kerthcet Awaiting requested review from kerthcet

@trasc trasc Awaiting requested review from trasc

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@ArangoGutierrez ArangoGutierrez

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ashish493 @k8s-ci-robot @ArangoGutierrez @tenzen-y @alculquicondor