Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport 2.19 - do not run etcd role in scale.yml playbook when etcd installed by kub… #9216

Merged
merged 1 commit into from
Aug 24, 2022
Merged

backport 2.19 - do not run etcd role in scale.yml playbook when etcd installed by kub… #9216

merged 1 commit into from
Aug 24, 2022

Conversation

LuckySB
Copy link
Contributor

@LuckySB LuckySB commented Aug 24, 2022

/kind bug

backport #9210

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 24, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 24, 2022
@LuckySB LuckySB changed the title do not run etcd role in scale.yml playbook when etcd installed by kub… backport 2.19 - do not run etcd role in scale.yml playbook when etcd installed by kub… Aug 24, 2022
floryut
floryut approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@floryut
Copy link
Member

floryut commented Aug 24, 2022

Thanks @LuckySB

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, LuckySB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6eb3135 into kubernetes-sigs:release-2.19 Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@EppO EppO Awaiting requested review from EppO

@liupeng0518 liupeng0518 Awaiting requested review from liupeng0518

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuckySB @floryut @k8s-ci-robot