Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not run etcd role in scale.yml playbook when etcd installed by kub… #9210

Merged
merged 1 commit into from
Aug 24, 2022
Merged

do not run etcd role in scale.yml playbook when etcd installed by kub… #9210

merged 1 commit into from
Aug 24, 2022

Conversation

LuckySB
Copy link
Contributor

@LuckySB LuckySB commented Aug 23, 2022 •
edited by floryut
Loading

/kind bug

What this PR does / why we need it:

when etcd_deployment_type: kubeadm
playbook scale.yml failed with this error:

2022-08-23 11:09:47,802 p=17209 u=root n=ansible | TASK [etcd : include_tasks] *******************************************************************************
***************************************************
2022-08-23 11:09:47,970 p=17209 u=root n=ansible | fatal: [master-1]: FAILED! => {"reason": "Could not find or access '/srv/install-cluster
/kubespray/install_kubeadm.yml' on the Ansible Controller."}```

on this task

- include_tasks: "install_{{ etcd_deployment_type }}.yml"
  when: is_etcd_master
  tags:
    - upgrade

Does this PR introduce a user-facing change?:

Do not run etcd role in `scale.yml` playbook when etcd installed by kubeadm

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LuckySB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 23, 2022
@k8s-ci-robot k8s-ci-robot requested review from EppO and holmsten August 23, 2022 16:02
@cristicalin
Copy link
Contributor

/lgtm

@LuckySB this might be a good candidate to back port to release-2.19 if you can manage it.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1c75ec9 into kubernetes-sigs:master Aug 24, 2022
LuckySB added a commit to LuckySB/kubespray that referenced this pull request Aug 24, 2022
@LuckySB
do not run etcd role in scale.yml playbook when etcd installed by kub…
d796489 
…eadm (kubernetes-sigs#9210)
@LuckySB LuckySB mentioned this pull request Aug 24, 2022
Merged
k8s-ci-robot pushed a commit that referenced this pull request Aug 24, 2022
@LuckySB
do not run etcd role in scale.yml playbook when etcd installed by kub…
6eb3135 
…eadm (#9210) (#9216)
TinLe added a commit to TinLe/kubespray that referenced this pull request Aug 27, 2022
@TinLe
Merge remote-tracking branch 'upstream/master'
3fa0d59 
* upstream/master: (832 commits)
  add pre-commit hook to facilitate local testing (kubernetes-sigs#9158)
  cri-dockerd: add restart of docker.service (kubernetes-sigs#9205)
  do not run etcd role in scale.yml playbook when etcd installed by kubeadm (kubernetes-sigs#9210)
  optimize the format of evictionHard in kubelet-config.yaml template (kubernetes-sigs#9204)
  Update vars.md (kubernetes-sigs#9172)
  fix one bug in docs/nodes (kubernetes-sigs#9203)
  Fix containerd (<1.7) configuration for insecure registries (kubernetes-sigs#9207)
  🌱 Enable cri-dockerd service (kubernetes-sigs#9201)
  Update vsphere-csi.md (kubernetes-sigs#9170)
  9035: Make Cilium rolling-restart delay/timeout configurable (kubernetes-sigs#9176)
  [kubernetes] Add hashes for 1.24.4, 1.22.13, 1.23.10 and make v1.24.4 default (kubernetes-sigs#9191)
  Add 'avoid-buggy-ips' support of MetalLB (kubernetes-sigs#9166)
  Add the option to enable default Pod Security Configuration (kubernetes-sigs#9017)
  Add 'flush ip6tables' task in reset role (kubernetes-sigs#9168)
  add list nodes rules to cilium-operator clusterrole (kubernetes-sigs#9178)
  docs(kube-vip): fix broken links (kubernetes-sigs#9165)
  Disable DNSStubListener for Flatcar Linux (kubernetes-sigs#9160)
  Subnet setup order fix & Number of master nodes syntax fix (kubernetes-sigs#9159)
  Fix CSI drivers issues on Azure (kubernetes-sigs#9153)
  [calico] calico rr supports multiple groups (kubernetes-sigs#9134)
  ...
alegrey91 pushed a commit to alegrey91/kubespray that referenced this pull request Aug 29, 2022
@LuckySB @alegrey91
do not run etcd role in scale.yml playbook when etcd installed by kub…
a178f3c 
…eadm (kubernetes-sigs#9210)
rptaylor pushed a commit to rptaylor/kubespray that referenced this pull request Aug 30, 2022
@LuckySB @rptaylor
do not run etcd role in scale.yml playbook when etcd installed by kub…
c560d49 
…eadm (kubernetes-sigs#9210)
@floryut floryut mentioned this pull request Sep 19, 2022
Closed
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@LuckySB @nolimitkun
do not run etcd role in scale.yml playbook when etcd installed by kub…
21f95d5 
…eadm (kubernetes-sigs#9210)
LuckySB added a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
@LuckySB
do not run etcd role in scale.yml playbook when etcd installed by kub…
089d02a 
…eadm (kubernetes-sigs#9210)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuckySB @k8s-ci-robot @cristicalin