[etcd] ensure etcd is properly upgraded when managed by kubeadm #8722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Closed
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jun 30, 2023
…rnetes-sigs#8722) * [etcd] ensure etcd is properly upgraded when managed by kubeadm * [CI] add periodic job to test upgrade of etcd managed by kubeadm
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Oct 23, 2023
…rnetes-sigs#8722) * [etcd] ensure etcd is properly upgraded when managed by kubeadm * [CI] add periodic job to test upgrade of etcd managed by kubeadm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR addresses an issue with ansible templating that results in the etcd cluster failing to be upgraded when
etcd_deployment_type == "kubeadm".The line above always results in
Falsesince ansible evaluates conversion operator|before the comparison operator==.This PR also adds a CI job to the periodic (nightly) run to test the upgrade with etcd managed by kubeadm so we can catch this kind of breakage in the future.
Which issue(s) this PR fixes:
Fixes #8721
Special notes for your reviewer:
Does this PR introduce a user-facing change?: