Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.14] Backport: Check kube-apiserver up on all masters before upgrade #7197

Merged
merged 1 commit into from
Jan 29, 2021
Merged

[2.14] Backport: Check kube-apiserver up on all masters before upgrade #7197

merged 1 commit into from
Jan 29, 2021

Conversation

RickHaan
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
Only checking the Kubernetes api on the first master when upgrading is not enough.
Each master needs to be checked before it's upgrade, otherwise the upgrade can fail if the api-server is not ready.

Which issue(s) this PR fixes:
#7099 for release 2.14

Special notes for your reviewer:
Cherry-pick/backport of #7193 (#7110) for the release-2.14 branch.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 20, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @RickHaan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 20, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2021
@LuckySB
Copy link
Contributor

LuckySB commented Jan 20, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2021
@RickHaan
Copy link
Contributor Author

The CI is failing on molecule_tests with TASK [cri-o : Install cri-o packages]:

failed: [ubuntu1804] (item=cri-o-1.17) => {"ansible_loop_var": "item", "attempts": 4, "changed": false, "item": "cri-o-1.17", "msg": "No package matching 'cri-o-1.17' is available"}

I have looked into it and it seems I need to backport #7003 to fix this issue.

@floryut
Copy link
Member

floryut commented Jan 22, 2021

The CI is failing on molecule_tests with TASK [cri-o : Install cri-o packages]:

failed: [ubuntu1804] (item=cri-o-1.17) => {"ansible_loop_var": "item", "attempts": 4, "changed": false, "item": "cri-o-1.17", "msg": "No package matching 'cri-o-1.17' is available"}

I have looked into it and it seems I need to backport #7003 to fix this issue.

Yup and it would be good to backport on 2.15 first :)

@RickHaan
Copy link
Contributor Author

It's already available in release-2.15 as can be seen here. I will create backports for release-2.14 and release-2.13.

@RickHaan RickHaan mentioned this pull request Jan 25, 2021
Merged
@RickHaan
Check kube-apiserver up on all masters before upgrade (#7193)
d039f8e 
Only checking the kubernetes api on the first master when upgrading is not enough.
Each master needs to be checked before it's upgrade.

Signed-off-by: Rick Haan <rickhaan94@gmail.com>
@oomichi
Copy link
Contributor

oomichi commented Jan 27, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2021
@RickHaan
Copy link
Contributor Author

/assign @mirwan

@LuckySB
Copy link
Contributor

LuckySB commented Jan 29, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LuckySB, RickHaan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit c3814bb into kubernetes-sigs:release-2.14 Jan 29, 2021
@RickHaan RickHaan mentioned this pull request Feb 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut Awaiting requested review from floryut

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@oomichi oomichi

@mirwan mirwan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RickHaan @k8s-ci-robot @LuckySB @floryut @oomichi @mirwan