bump crio version to 1.19 #6758

hafe · 2020-09-27T18:13:12Z

note that crio upgrade does not work, see #6757

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

Use latest crio aligned with k8 version.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

k8s-ci-robot · 2020-09-27T18:13:20Z

Hi @hafe. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

floryut · 2020-09-28T07:45:22Z

/ok-to-test

floryut · 2020-09-28T07:47:16Z

roles/container-engine/cri-o/defaults/main.yml

@@ -24,8 +24,9 @@ crio_stream_port: "10010"
 crio_required_version: "{{ kube_version | regex_replace('^v(?P<major>\\d+).(?P<minor>\\d+).(?P<patch>\\d+)$', '\\g<major>.\\g<minor>') }}"

 crio_kubernetes_version_matrix:
+  "1.19": "1.19"
  "1.18": "1.18"
  "1.17": "1.17"
  "1.16": "1.16"


You can remove this line, 1.16 should not be needed anymore

sorry missed that, will do, probably 1.17 also right?

Yes not sure as we are in quite a weird state, still supporting 1.17 while at the same time not supporting it for future 2.15 :/

(I would keep it for now)

floryut · 2020-09-28T07:47:55Z

failed: [ubuntu1804] (item=cri-o-1.19) => {"ansible_loop_var": "item", "attempts": 4, "changed": false, "item": "cri-o-1.19", "msg": "No package matching 'cri-o-1.19' is available"}

Looks like ubuntu18 is not quite ready for that, maybe pin a specific version (lower) for it ?

hafe · 2020-09-29T07:21:15Z

failed: [ubuntu1804] (item=cri-o-1.19) => {"ansible_loop_var": "item", "attempts": 4, "changed": false, "item": "cri-o-1.19", "msg": "No package matching 'cri-o-1.19' is available"}
Looks like ubuntu18 is not quite ready for that, maybe pin a specific version (lower) for it ?

Turned out the package name had changed! That will affect upgrades...
Official crio docs for install now seems to be working

floryut · 2020-09-29T07:22:44Z

failed: [ubuntu1804] (item=cri-o-1.19) => {"ansible_loop_var": "item", "attempts": 4, "changed": false, "item": "cri-o-1.19", "msg": "No package matching 'cri-o-1.19' is available"}
Looks like ubuntu18 is not quite ready for that, maybe pin a specific version (lower) for it ?
Turned out the package name had changed! That will affect upgrades...
Official crio docs for install now seems to be working

Oh, nice

hafe · 2020-09-29T09:20:18Z

Great so now fedora is failing when Ubuntu made it ☹️

hafe · 2020-09-29T17:18:45Z

I skipped Fedora since I have no clue how it works

oomichi

/cc @oomichi

oomichi · 2020-09-29T22:53:56Z

roles/container-engine/cri-o/vars/fedora.yml

+  "1.18": "1.18"
+  "1.17": "1.17"
+
+crio_version: "{{ crio_kubernetes_version_matrix[crio_required_version] | default('1.17') }}"


It would be better to add # NOTE: Need to specify 1.17 for fedora instead of the default 1.19 due to test failure or something because it is a little tricky to specify different version here from the default one.

* crio package name has changed for debian/ubuntu * crio upgrade does not work, see kubernetes-sigs#6757

oomichi · 2020-09-30T16:01:27Z

Thanks for updating.

/lgtm

floryut · 2020-10-09T08:04:58Z

@hafe Looks good to me, could you update the README as cri-o version is specified there ?

hafe · 2020-10-09T08:08:51Z

@hafe Looks good to me, could you update the README as cri-o version is specified there ?

Sure

hafe · 2020-10-09T10:00:37Z

There is also docs/crio.md that need some updates. It says scale is not supported, why would that be?
Update I have in the pipe

floryut · 2020-10-09T10:12:28Z

There is also docs/crio.md that need some updates. It says scale is not supported, why would that be?
Update I have in the pipe

Indeed, but those comments are 2years old so it might (should) need some update.
Could be done in another PR anyway, no rush to do it here, up to you.

EppO · 2020-10-10T00:18:45Z

/lgtm

woopstar · 2020-10-13T09:05:45Z

/approve

k8s-ci-robot · 2020-10-13T09:06:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hafe, woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [woopstar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* 'master' of https://github.com/kubernetes-sigs/kubespray: Disable audio device mapping for VirtualBox VMs (kubernetes-sigs#6811) bump crio version to 1.19 (kubernetes-sigs#6758)

* bump crio version to 1.19 * crio package name has changed for debian/ubuntu * crio upgrade does not work, see kubernetes-sigs#6757 * update crio info in docs

* cherry-pick bump crio version to 1.19 (#6758) cherry-pick modifications: * keep default to 1.17 as release 2.14 came with * don't change readme with newer versions * bump crio version to 1.19 * crio package name has changed for debian/ubuntu * crio upgrade does not work, see #6757 * update crio info in docs * Install cri-o with package version (#6853) and thereby support upgrade from e.g. 1.18.x to 1.19.y Included OSes: - Centos7/8 - Ubuntu18/20 New variables for overriding by default installed packages: - centos_crio_packages - ubuntu_crio_packages * add support crio version for varios k8s vers (#7003) * add support crio version for various k8s vers * regexp in pkg versions Co-authored-by: Hans Feldt <2808287+hafe@users.noreply.github.com> Co-authored-by: Sergey <s.bondarev@southbridge.ru>

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 27, 2020

k8s-ci-robot requested review from bozzo and EppO September 27, 2020 18:13

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 27, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 28, 2020

floryut reviewed Sep 28, 2020

View reviewed changes

hafe force-pushed the crio-1.19 branch from 01e5734 to 4669dfb Compare September 29, 2020 07:18

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 29, 2020

hafe force-pushed the crio-1.19 branch from 4669dfb to 119e68e Compare September 29, 2020 08:46

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2020

hafe force-pushed the crio-1.19 branch from 119e68e to 6012a78 Compare September 29, 2020 16:05

oomichi reviewed Sep 29, 2020

View reviewed changes

k8s-ci-robot requested a review from oomichi September 29, 2020 22:54

bump crio version to 1.19

ed9c096

* crio package name has changed for debian/ubuntu * crio upgrade does not work, see kubernetes-sigs#6757

hafe force-pushed the crio-1.19 branch from 6012a78 to ed9c096 Compare September 30, 2020 06:35

k8s-ci-robot assigned oomichi Sep 30, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2020

update crio info in docs

a5a314c

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2020

k8s-ci-robot assigned EppO Oct 10, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2020

k8s-ci-robot merged commit 4781df5 into kubernetes-sigs:master Oct 13, 2020

RickHaan mentioned this pull request Jan 25, 2021

[2.14] Backport: 6758, 6853 and 7003 to fix CRI-O pkg #7209

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump crio version to 1.19 #6758

bump crio version to 1.19 #6758

hafe commented Sep 27, 2020

k8s-ci-robot commented Sep 27, 2020

floryut commented Sep 28, 2020

floryut Sep 28, 2020

hafe Sep 29, 2020

floryut Sep 29, 2020

floryut Sep 29, 2020

floryut commented Sep 28, 2020

hafe commented Sep 29, 2020

floryut commented Sep 29, 2020

hafe commented Sep 29, 2020

hafe commented Sep 29, 2020

oomichi left a comment

oomichi Sep 29, 2020

hafe Sep 30, 2020

oomichi commented Sep 30, 2020

floryut commented Oct 9, 2020

hafe commented Oct 9, 2020

hafe commented Oct 9, 2020

floryut commented Oct 9, 2020 •

edited

Loading

EppO commented Oct 10, 2020

woopstar commented Oct 13, 2020

k8s-ci-robot commented Oct 13, 2020

bump crio version to 1.19 #6758

bump crio version to 1.19 #6758

Conversation

hafe commented Sep 27, 2020

k8s-ci-robot commented Sep 27, 2020

floryut commented Sep 28, 2020

floryut Sep 28, 2020

Choose a reason for hiding this comment

hafe Sep 29, 2020

Choose a reason for hiding this comment

floryut Sep 29, 2020

Choose a reason for hiding this comment

floryut Sep 29, 2020

Choose a reason for hiding this comment

floryut commented Sep 28, 2020

hafe commented Sep 29, 2020

floryut commented Sep 29, 2020

hafe commented Sep 29, 2020

hafe commented Sep 29, 2020

oomichi left a comment

Choose a reason for hiding this comment

oomichi Sep 29, 2020

Choose a reason for hiding this comment

hafe Sep 30, 2020

Choose a reason for hiding this comment

oomichi commented Sep 30, 2020

floryut commented Oct 9, 2020

hafe commented Oct 9, 2020

hafe commented Oct 9, 2020

floryut commented Oct 9, 2020 • edited Loading

EppO commented Oct 10, 2020

woopstar commented Oct 13, 2020

k8s-ci-robot commented Oct 13, 2020

floryut commented Oct 9, 2020 •

edited

Loading