Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RHEL support subscription registration #6572

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Add RHEL support subscription registration #6572

merged 1 commit into from
Nov 24, 2020

Conversation

bmelbourne
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
The new Red Hat support subscription registration feature will allow developers and administrators to deploy Kubespray across RHEL 7/8 hosts using Red Hat support account credentials, or an Organization ID/Activation Key combination.

A valid Red Hat support subscription is required to download packages from the RHEL 7/8 repositories via yum or dnf.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 21, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @bmelbourne. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 21, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 21, 2020
@floryut
Copy link
Member

floryut commented Aug 21, 2020 •
edited
Loading

You know that you don't have to close the PR at all, you can delete the branch locally, change everything you want, force push and the PR will be updated 😄
Anyway.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2020
@bmelbourne
Copy link
Contributor Author

bmelbourne commented Aug 21, 2020 •
edited
Loading

You know that you don't have to close the PR at all, you can delete the branch locally, change everything you want, force push and the PR will be updated 😄
Anyway.

/ok-to-test

Thanks for the advice @floryut

As I start creating these initial PRs, I'm on a steep learning curve when it comes to working with upstream repos and forked local repos. I'm getting to know what options are available when things get stuck in the CI tests.

@bmelbourne
Copy link
Contributor Author

/assign @mattymo

This was referenced Aug 27, 2020
Merged
Closed
@bmelbourne
Copy link
Contributor Author

@mattymo
All of the CI tests are now passing.

@floryut
Copy link
Member

floryut commented Sep 8, 2020

@bmelbourne why are you force pushing and repushing pretty much the same changes ? except overloading the CI 🤔

@bmelbourne
Copy link
Contributor Author

bmelbourne commented Sep 8, 2020 •
edited
Loading

@bmelbourne why are you force pushing and repushing pretty much the same changes ? except overloading the CI 🤔

I'm just keeping the PR up-to-date with the latest master commits ready for the review (checking for any merge conflicts), as this is what I've been asked to do prior to any review being started 🤔

I'm happy to stop doing it if reviewers don't require a rebase.

@floryut
Copy link
Member

floryut commented Sep 8, 2020

@bmelbourne why are you force pushing and repushing pretty much the same changes ? except overloading the CI 🤔

I'm just keeping the PR up-to-date with the latest master commits ready for the review (checking for any merge conflicts), as this is what I've been asked to do prior to any review being started 🤔

I'm happy to stop doing it if reviewers don't require a rebase.

Please don't 😄
As long as the PR don't have any conflict/merge issues (Github auto detect that and put a flag need-rebase if so) you are good to go

@EppO
Copy link
Contributor

EppO commented Sep 11, 2020

we have no way to test this in the CI though... any RH subscription to spare, anyone?? :)

@bmelbourne
Copy link
Contributor Author

we have no way to test this in the CI though... any RH subscription to spare, anyone?? :)

@EppO
It's possible to create a Red Hat Developer's account which will provide a 1-year support subscription, this could then used by the CI pipeline temporarily. As a more permanent solution, we could reach out to our Red Hat Kubernetes network and ask them to set-up a non-expiring support account subscription for Kubespray CI??

After all this does benefit Red Hat organisation in that users will have reassurance that Kubespray has been tested and deployed on RHEL 7/8 machines.

@floryut
Copy link
Member

floryut commented Sep 14, 2020

we have no way to test this in the CI though... any RH subscription to spare, anyone?? :)

@EppO
It's possible to create a Red Hat Developer's account which will provide a 1-year support subscription, this could then used by the CI pipeline temporarily. As a more permanent solution, we could reach out to our Red Hat Kubernetes network and ask them to set-up a non-expiring support account subscription for Kubespray CI??

After all this does benefit Red Hat organisation in that users will have reassurance that Kubespray has been tested and deployed on RHEL 7/8 machines.

Yup even the CNCF might help us with that (as we are under their umbrella)

@EppO
Copy link
Contributor

EppO commented Sep 15, 2020

in the meantime, I don't see any reasons not to merge this

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2020
Miouge1
Miouge1 suggested changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@Miouge1 Miouge1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mixed thoughts about this PR.

On one hand I understand that a registration is required to download packages than we need for Kubespray.

On the other hand, a bunch of other things are also required to download packages: IP configuration, DNS, etc... things which we take for granted or are just requirements.

What do you think?

Vagrantfile Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2020
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 22, 2020
@bmelbourne bmelbourne requested a review from Miouge1 October 23, 2020 08:27
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmelbourne, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2020
@bmelbourne
Copy link
Contributor Author

/retest

@floryut
Copy link
Member

floryut commented Nov 24, 2020

As this was approved and lgtmed, let's merge

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit eb16986 into kubernetes-sigs:master Nov 24, 2020
@bmelbourne bmelbourne deleted the add-rhel-subscription-registration branch December 1, 2020 18:35
@floryut floryut mentioned this pull request Dec 19, 2020
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
@bmelbourne @LuckySB
Add RHEL support subscription registration (kubernetes-sigs#6572)
c74d89a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miouge1 Miouge1 Miouge1 approved these changes

@floryut floryut Awaiting requested review from floryut

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@EppO EppO

@mattymo mattymo

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bmelbourne @k8s-ci-robot @floryut @EppO @Miouge1 @mattymo