Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2.12] fix test if openstack_cacert is a base64 string #6371

Merged
merged 1 commit into from
Aug 4, 2020
Merged

[v2.12] fix test if openstack_cacert is a base64 string #6371

merged 1 commit into from
Aug 4, 2020

Conversation

mariob1626
Copy link

@mariob1626 mariob1626 commented Jul 3, 2020 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR fix copy of opesntack_cacert into VM. Currently task Test if openstack_cacert is a base64 string always evaluate opesnstack_cacert as base64 even if it's path to a file. This is leading to wrong openstack-cacert.pem file on VM and thus failing kubelet to start.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Instead of decode openstack_cacert which returns true because it will decode also path to file I found other way to check whether string is base64 or not https://www.thetopsites.net/article/53142215.shtml
It've been testing and now it returns True and False if the varialbe is base64 or not.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 3, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @mariobris. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from holmsten and mirwan July 3, 2020 10:38
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2020
@mariob1626 mariob1626 changed the title fix test if openstack_cacert is a base64 string [v.2.12] fix test if openstack_cacert is a base64 string Jul 3, 2020
@mariob1626 mariob1626 changed the title [v.2.12] fix test if openstack_cacert is a base64 string [v2.12] fix test if openstack_cacert is a base64 string Jul 3, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 3, 2020
@floryut
Copy link
Member

floryut commented Jul 6, 2020

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 6, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2020
@LuckySB
Copy link
Contributor

LuckySB commented Jul 7, 2020

/approve

@Miouge1
Copy link
Contributor

Miouge1 commented Jul 13, 2020 •
edited
Loading

/hold

Backports needs to be merged in master before being back ported

From what I see, this is not currently in master: https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes/node/tasks/main.yml#L193

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2020
@mariob1626
Copy link
Author

@Miouge1 what needs to be done then ? I see there is branch for 2.12 version which is probably not being merged from/with master. I'd like to understand how to do it next time.

@floryut
Copy link
Member

floryut commented Jul 14, 2020

@Miouge1 what needs to be done then ? I see there is branch for 2.12 version which is probably not being merged from/with master. I'd like to understand how to do it next time.

Change your PR (or open a new one) targetting master :)

@floryut floryut mentioned this pull request Jul 17, 2020
Merged
@floryut
Copy link
Member

floryut commented Jul 30, 2020

/unhold PR on master is now merged

@floryut
Copy link
Member

floryut commented Jul 30, 2020

@Miouge1 if you can unhold 👍

@EppO
Copy link
Contributor

EppO commented Jul 30, 2020 •
edited
Loading

/hold cancel

commands need to be put on a single line :)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2020
@floryut
Copy link
Member

floryut commented Jul 30, 2020

/hold cancel

commands need to be put on a single line :)

Oh my 🤦 thx 👍

@Miouge1
Copy link
Contributor

Miouge1 commented Jul 30, 2020

Is that it's master, we should backport in 2.13 before 2.12.

@floryut
Copy link
Member

floryut commented Jul 30, 2020

Is that it's master, we should backport in 2.13 before 2.12.

Indeed, PR-ing right now

@floryut floryut mentioned this pull request Jul 30, 2020
Merged
@Miouge1
Copy link
Contributor

Miouge1 commented Aug 4, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LuckySB, mariobris, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2acc5a7 into kubernetes-sigs:release-2.12 Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmsten holmsten Awaiting requested review from holmsten

@mirwan mirwan Awaiting requested review from mirwan

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mariob1626 @k8s-ci-robot @floryut @LuckySB @Miouge1 @EppO