Use k8s.gcr.io for kubernetes related images #5764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
|
/assign @LuckySB |
|
Pipeline passed but GitHub didn't get the completion feedback apparently. |
|
#5646 is updating and fixing metrics-server for 1.16, I'll remove it from my PR |
k8s-ci-robot
added
size/XS
EppO
force-pushed
the
use_k8s.gcr.io_repo
branch
from
3565868 to
8c7ae26
Compare
Miouge1
reviewed
Mar 13, 2020
k8s-ci-robot
added
the
needs-rebase
EppO
force-pushed
the
use_k8s.gcr.io_repo
branch
from
169c120 to
ce82825
Compare
k8s-ci-robot
removed
the
needs-rebase
|
Looks good, let's see what CI says /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EppO, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Mar 14, 2020
* Use k8s.gcr.io for kubernetes related images * Use k8s.gcr.io in inventory sample
k8s-ci-robot
pushed a commit
that referenced
this pull request
Sep 18, 2020
* Use k8s.gcr.io for kubernetes related images (#5764) * Use k8s.gcr.io for kubernetes related images * Use k8s.gcr.io in inventory sample * [2.12] Update hashes and set default version to 1.16.14 * [2.12] Update hashes and set default version to 1.16.15 Co-authored-by: Florent Monbillard <f.monbillard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
gcr.io/google-containerswill be replaced bygcr.io/k8s-artifacts-prodsoon (early April). Using k8s.gcr.io should be safe until the cutoff is done and even after.Which issue(s) this PR fixes:
Fixes #5711
Special notes for your reviewer:
I didn't address the dashboard image as they moved it to dockerhub for the latest releases. Current version is actually not compatible with 1.16.x. It should be addressed in a separate PR.
Does this PR introduce a user-facing change?: