add to inventory.py script ability to indicate ip ranges #4182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
mattymo
reviewed
Feb 5, 2019
| reworked_hosts = [] | ||
|
|
||
| def ips(start_address, end_address): | ||
| from ipaddress import ip_address |
There was a problem hiding this comment.
move the import up to line 184
mattymo
reviewed
Feb 5, 2019
| return [ip_address(ip).exploded for ip in range(start, end+1)] | ||
|
|
||
| for host in hosts: | ||
| if '-' in host: |
There was a problem hiding this comment.
Can we wrap this in a try/except block? I want to print an error and exit if an ip address range is specified wrong
|
Please add a test case for adding a valid and an invalid IP range to contrib/inventory_builder/tests/test_inventory.py |
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattymo, tikitavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Feb 18, 2019
…sigs#4182) * add to inventory.py script ability to indicate ip ranges * add test for range2ip function for inventory.py script some fixes * add negative test for range2ip function for inventory.py script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.