Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix apiServerCertSANs in kubeadm config file #3839

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Fix apiServerCertSANs in kubeadm config file #3839

merged 1 commit into from
Dec 7, 2018

Conversation

pasqualet
Copy link
Contributor

resolve #3838

@k8s-ci-robot k8s-ci-robot requested review from Atoms and mirwan December 7, 2018 00:33
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 7, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 7, 2018
@pasqualet
Copy link
Contributor Author

CLA signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 7, 2018
@twexler
Copy link
Contributor

twexler commented Dec 7, 2018 •
edited
Loading

It looks like I got bit by this too. I think the offending commit was ddc19f4, part of #3766

@woopstar
Copy link
Member

woopstar commented Dec 7, 2018

ci check this

@riverzhang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2018
@riverzhang
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pasqualet, riverzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit ea833a4 into kubernetes-sigs:master Dec 7, 2018
verwilst pushed a commit to verwilst/kubespray that referenced this pull request Dec 18, 2018
@pasqualet @verwilst
Fix apiServerCertSANs in kubeadm config file (kubernetes-sigs#3839)
36ae42d
@verwilst verwilst mentioned this pull request Dec 18, 2018
Merged
k8s-ci-robot pushed a commit that referenced this pull request Dec 26, 2018
@verwilst @k8s-ci-robot
More Feature/2.8 backports for 2.8.1 (#3911)
2ac1c75 
* Move node-cidr-mask-size to ControllerManagerextraArgs (#3845)

* Fix apiServerCertSANs in kubeadm config file (#3839)

* Backport #3908

* Update kubernetes to 1.12.4
spisarski pushed a commit to cablelabs/kubespray that referenced this pull request Feb 11, 2019
@verwilst @spisarski
More Feature/2.8 backports for 2.8.1 (kubernetes-sigs#3911)
742681f 
* Move node-cidr-mask-size to ControllerManagerextraArgs (kubernetes-sigs#3845)

* Fix apiServerCertSANs in kubeadm config file (kubernetes-sigs#3839)

* Backport kubernetes-sigs#3908

* Update kubernetes to 1.12.4
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Feb 17, 2019
@pasqualet @LuckySB
Fix apiServerCertSANs in kubeadm config file (kubernetes-sigs#3839)
6a4ae9f
@rptaylor rptaylor mentioned this pull request Apr 4, 2019
Closed
@naveen1003
Copy link

CLA signed

@pasqualet pasqualet mentioned this pull request Nov 9, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atoms Atoms Awaiting requested review from Atoms

@mirwan mirwan Awaiting requested review from mirwan

Assignees

@riverzhang riverzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Master nodes fails the kubeadm upgrade command when they have the access_ip variable set
6 participants
@pasqualet @k8s-ci-robot @twexler @woopstar @riverzhang @naveen1003