Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only apply roles from first master node to fix regression #2490

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Only apply roles from first master node to fix regression #2490

merged 1 commit into from
Mar 22, 2018

Conversation

woopstar
Copy link
Member

The following regression happend where master 2 completed before 01. No need to apply the same clusterroles multiple times. Only do it from master 1.

TASK [kubernetes-apps/cluster_roles : Apply workaround to allow all nodes with cert O=system:nodes to register] *************************
Sunday 18 March 2018  16:09:13 +0100 (0:00:01.164)       0:17:40.526 **********
ok: [odn1-kube-cluster01-master02] => {"changed": false, "msg": "success: clusterrolebinding \"kubespray:system:node\" created"}
fatal: [odn1-kube-cluster01-master01]: FAILED! => {"changed": false, "msg": "error running kubectl (/opt/bin/kubectl apply --force --filename=/etc/kubernetes/node-crb.yml) command (rc=1), out='', err='Error from server (AlreadyExists): error when creating \"/etc/kubernetes/node-crb.yml\": clusterrolebindings.rbac.authorization.k8s.io \"kubespray:system:node\" already exists\n'"}
ok: [odn1-kube-cluster01-master03] => {"changed": false, "msg": "success: clusterrolebinding \"kubespray:system:node\" configured"}

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 18, 2018
@woopstar
Copy link
Member Author

@kongslund Could you verify this?

@kongslund
Copy link
Contributor

Good catch. I will try it out.

@chadswen
Copy link
Member

ci check this

@chadswen chadswen merged commit 0e6b4e8 into kubernetes-sigs:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadswen chadswen chadswen approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@woopstar @kongslund @chadswen @k8s-ci-robot